Opened 3 years ago

Closed 3 years ago

#21197 closed enhancement (fixed)

Poset documentation polishing: Graphs

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-7.4
Component: documentation Keywords:
Cc: kdilks, ​darij Merged in:
Authors: Jori Mäntysalo Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: cd39820 (Commits) Commit: cd3982022709c7fcb322a38ebadd7f4babe5b256
Dependencies: Stopgaps:

Description (last modified by jmantysalo)

Check documentation for poset functions that returns a (di)graph.

Changes are minor things, just unifying some wording, moving examples that are clearly tests to tests-block etc. Also

  • Remove wrapped-parameter from hasse_diagram(), as it did nothing.
  • Fix typo in lattices.py, "quantum" was in wrong place.
  • Move breath() last in list in lattices.py, as other functions return a Boolean value.

This continues the serie of #18925, #18941, #18959, #19141, #19360, #19435.

Change History (12)

comment:1 Changed 3 years ago by jmantysalo

  • Branch set to u/jmantysalo/poset-graphs

comment:2 Changed 3 years ago by git

  • Commit set to de0e9dbb3b8c66cd871caa96c2824943399ddc88

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

de0e9dbSome bikeshedding to poset functions that return a graph.

comment:3 Changed 3 years ago by jmantysalo

  • Cc kdilks ​darij added
  • Description modified (diff)

Kevin, I am continuing this serie. Compiling now, so not ready for review yet.

Darij: An example in frank_network contains numbers 12, -13, 14 and 16. Is there some reason for that?

comment:4 Changed 3 years ago by git

  • Commit changed from de0e9dbb3b8c66cd871caa96c2824943399ddc88 to cd3982022709c7fcb322a38ebadd7f4babe5b256

Branch pushed to git repo; I updated commit sha1. New commits:

cd39820A correction.

comment:5 Changed 3 years ago by jmantysalo

  • Status changed from new to needs_review

Kevin, maybe you can check this; we can check come back to frank_network later.

...polynomials next... this serie seems to take a year or two.

comment:6 Changed 3 years ago by jmantysalo

Just pinging.

comment:7 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be. Even if I do not see the point of changing all the doctests..

comment:8 Changed 3 years ago by kdilks

Are you able to run the doctests? After applying this ticket, I was able to run doctests for unchanged files and lattices.py, but when I tried to test posets.py it just hangs until I force quit, where it shows it was using 0 CPU time. Currently upgrading from 7.4beta1 to 7.3beta3 to see if that makes a difference.

comment:9 Changed 3 years ago by chapoton

hum, one patchbot is happy with the doctests, so I did not double check.

There was a problem indeed about some test in posets.py in 7.4.beta(1-2), that has been solved in 7.4.b3

Last edited 3 years ago by chapoton (previous) (diff)

comment:10 Changed 3 years ago by kdilks

Alright, I just finished updating to 7.4b3 and it does work now.

comment:11 Changed 3 years ago by jmantysalo

Thanks!

I am gradually checking posets.py, and trying to make meaningful examples in the process. Next will be polynomials; for example order_polynomial() should use as_ideals=False when calling order_ideals_lattice() and so on.

comment:12 Changed 3 years ago by vbraun

  • Branch changed from u/jmantysalo/poset-graphs to cd3982022709c7fcb322a38ebadd7f4babe5b256
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.