Upgrade autotools

[mkoeppe]

Upgrade autotools to the latest upstream versions, for no particular reason.

[mkoeppe]

The branch attempts to upgrade the autotools versions. Building currently fails because libtool 2.4.3's patches against gnulib stuff do not apply cleanly when gnulib is too new.

---

New commits:

​da4a28f	Use Sage m4 to build libtool
​d70e858	Add xz as dependency
​b2095e1	Merge tag '7.3.beta9' into t/21047/_sage__i_autotools__fails_because_libtool_2_4_3_requires_xz
​e09aaf3	Expand discussion about M4
​ff3f2b3	Merge tag '7.3' into t/21047/_sage__i_autotools__fails_because_libtool_2_4_3_requires_xz
​59fb410	Install symlinks bin/{aclocal,automake}-AM_API_VERSION
​72269cc	spkg-write-makefile: Remove dependency on GNU sed
​ce2b490	spkg-write-makefile: Fix wrong prereq in automake 1.10
​ba06f0e	Supply .serial file for libtool
​d794672	Upgrade autotools versions

[mkoeppe]

(Branch is on top of #21047.)

[embray]

Ah, I was just in the process of trying to do this myself (as I guess you saw on the ML). Thanks for adding me.

[embray]

Did you ever find a workaround to the issue of libtool 2.4.3 and gnulib? I have an idea for that that I'm testing now.

[embray]

Here's my idea--it worked for me. The idea is that there is an optional gnulib version appended to the libtool version (with a +). If given, it will check out that tag from the gnulib repo before building (otherwise it defaults to the master branch, which worked for all but libtool 2.4.3 anyways).

I admit the syntax is a bit awkward and am open to other ideas. I just didn't want to hard-code a special case just for this version (though that might be acceptable as well given that it ended up being the only one affected AFAICT).

build/pkgs/autotools/spkg-write-makefile

@@ -90 +90 @@
     all="$p-all:"
     for v in $*
     do
+        # Split the version into the package version and the required gnulib version
+        # if any; by default just use the master branch of gnulib
+        gnulib_ver="master"
+        if [[ "$v" == *+* ]]; then
+            gnulib_ver=${v#*+}
+            v=${v%+*}
+        fi
+
         echo >&2 "Processing $p-$v"
         cd $p
 
@@ -115 +123 @@
             if [ ! -f configure ]; then
                 # libtool-2.4.3 requires some gnulib files
                 if [ -d gnulib ]; then
+                    echo >&2 "Preparing gnulib ${gnulib_ver}"
+                    cd ../gnulib
+                    git checkout "${gnulib_ver}"
+                    cd ../$p
+
                     cp -a ../gnulib/build-aux .
                 fi
                 # Run aclocal, such that AM_INIT_AUTOMAKE is available.
@@ -201 +214 @@
         [ -z "$lt_ver" ] || echo -e "\texport LIBTOOL_VERSION=$lt_ver ; \\\\"
         [ -z "$ac_ver" ] || echo -e "\texport AUTOCONF_VERSION=$ac_ver ; \\\\"
         [ -z "$am_ver" ] || echo -e "\texport AUTOMAKE_VERSION=$am_ver ; \\\\"
-       echo -e "\tcd $p-$v && ${bootstrap}\\\\"
-       echo -e "\t    ./configure --prefix=\"\$(SAGE_LOCAL)/$p-$v\" && \\\\"
-       echo -e "\t    \$\$MAKE && \$\$MAKE install"
-       echo -e "\t# Remove all files except for the .* files"
-       echo -e "\t[ \"\$\$SAGE_KEEP_BUILT_SPKGS\" = yes ] || rm -rf $p-$v/*"
+
+    if [ $p = libtool -a -d gnulib ]; then
+        echo -e "\t(cd \$(SRC)/gnulib && git checkout ${gnulib_ver}) && \\\\"
+    fi
+    echo -e "\tcd $p-$v && ${bootstrap}\\\\"
+    echo -e "\t    ./configure --prefix=\"\$(SAGE_LOCAL)/$p-$v\" && \\\\"
+    echo -e "\t    \$\$MAKE && \$\$MAKE install"
+    echo -e "\t# Remove all files except for the .* files"
+    echo -e "\t[ \"\$\$SAGE_KEEP_BUILT_SPKGS\" = yes ] || rm -rf $p-$v/*"
         echo
 
         prevextract="$p-$v/.tarball-version"

build/pkgs/autotools/version-list

@@ -15 +15 @@
     1.9 1.9.1 1.9.2 1.9.3 1.9.4 1.9.5 1.9.6 1.10 1.10.1 1.10.2 1.10.3
     1.11 1.11.1 1.11.2 1.11.3 1.11.4 1.11.5 1.11.6 1.12 1.12.1 1.12.2
     1.12.3 1.12.4 1.12.5 1.12.6 1.13 1.13.1 1.13.2 1.13.3 1.13.4
-    1.14 1.14.1"
+    1.14 1.14.1 1.15"
 
 libtool_versions="
     1.5.20 1.5.22 1.5.24 1.5.26
     2.2.4 2.2.6 2.2.6b 2.2.8 2.2.10
-    2.4 2.4.2 2.4.3"
+    2.4 2.4.2 2.4.3+v0.1-253-ge28a0f7
+    2.4.4 2.4.5 2.4.6"
+
+m4_version=1.4.17
+
+help2man_version=1.47.4
+
+texinfo_version=4.13

[embray]

Turns out I was wrong--gnulib master does not work some of the later libtool versions as well. A simpler solution looks like it might be to just use the same gnulib version across all of them.

[embray]

BTW, a more general bug--when I tried the spkg-src it failed at source version-list since it cds to a different directory before the source command, which should come earlier.

[mkoeppe]

Replying to embray:

BTW, a more general bug--when I tried the spkg-src it failed at source version-list since it cds to a different directory before the source command, which should come earlier.

Do you mean spkg-write-makefile instead of spkg-src?

[mkoeppe]

Replying to embray:

Turns out I was wrong--gnulib master does not work some of the later libtool versions as well. A simpler solution looks like it might be to just use the same gnulib version across all of them.

"all of them" = all versions or all currently failing versions?

which gnullib version would you want to use?

[mkoeppe]

I think there's also a similar problem with texinfo. Old autotools versions break with texinfo >= 5; and IIRC, some newer autotools versions I think need texinfo >= 5.

[embray]

Replying to mkoeppe:

Replying to embray:

BTW, a more general bug--when I tried the spkg-src it failed at source version-list since it cds to a different directory before the source command, which should come earlier.

Do you mean spkg-write-makefile instead of spkg-src?

No: ​https://git.sagemath.org/sage.git/diff/build/pkgs/autotools/spkg-src?id=527d09f4cf53eb2f9972aff4b9451823bda76fd9

[embray]

Replying to mkoeppe:

Replying to embray:

Turns out I was wrong--gnulib master does not work some of the later libtool versions as well. A simpler solution looks like it might be to just use the same gnulib version across all of them.

"all of them" = all versions or all currently failing versions?

which gnullib version would you want to use?

I found git checkout v0.1-253-ge28a0f7 on gnulib to work on all the versions of libtool both before this ticket, and the ones added by this ticket.

[embray]

Replying to mkoeppe:

I think there's also a similar problem with texinfo. Old autotools versions break with texinfo >= 5; and IIRC, some newer autotools versions I think need texinfo >= 5.

I didn't run into this particular problem but maybe I didn't try it on any packages that use texinfo. Can you point to a specific example?

[dimpase]

ping?

[saraedum]

What should we do about this ticket? Should we try to upgrade? (I could try to work on this…)

[mkoeppe]

See also - #24903 optional package autotools fail to build

[saraedum]

If we decide to drop autotools in #24903, then this can be closed.

[saraedum]

I propose to make autotools experimental and drop it some day. I don't think we should put too much effort into upgrading this.

If somebody else wants to take over with the upgrade (and has a system where this actually builds) they should feel free to take over of course :)

[vdelecroix]

closing positively reviewed duplicates