Opened 4 years ago

Closed 4 years ago

#21184 closed enhancement (fixed)

code cleanup in link and linear_functions

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.4
Component: PLEASE CHANGE Keywords:
Cc: tscrim, leif, darij Merged in:
Authors: Frédéric Chapoton Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: e9cdfb4 (Commits) Commit: e9cdfb4a627d37445079e54e9fea05397a8abe15
Dependencies: Stopgaps:

Description

  • in link.py:

remove a few cmp() and rewrite two sum

  • in linear_functions.pyx:

remove a cmp(), using .sign instead

Change History (4)

comment:1 Changed 4 years ago by chapoton

  • Branch set to public/21184
  • Commit set to e9cdfb4a627d37445079e54e9fea05397a8abe15
  • Status changed from new to needs_review

New commits:

e9cdfb4code cleanup in links and linear_function (cmp removal and better sums)

comment:2 Changed 4 years ago by chapoton

  • Cc tscrim leif darij added

bot is green, please review (should be an easy one)

comment:3 Changed 4 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 4 years ago by vbraun

  • Branch changed from public/21184 to e9cdfb4a627d37445079e54e9fea05397a8abe15
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.