#21175 closed enhancement (fixed)
Set ARCHFLAGS environment variable - for Perl modules
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.4 |
Component: | build | Keywords: | |
Cc: | vdelecroix, jdemeyer, embray, vbraun, tmonteil, dimpase, kcrisman | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | 78f2cfa (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | Stopgaps: |
Description (last modified by )
To make installing Perl modules easier on Mac OS X, we should set the ARCHFLAGS environment variable. This is to make sure that the output of perl -MExtUtils::Embed -e ldopts
and perl -MExtUtils::Embed -e ccflags
(picked up from system perl
) do not contain -arch
flags incompatible with our gcc.
This simplifies perl_term_readline_gnu
(#20894), polymake
(#20892), and makes installing pypolymake
(#21170) as a pip package possible.
Change History (17)
comment:1 Changed 6 years ago by
- Description modified (diff)
comment:2 Changed 6 years ago by
- Branch set to u/mkoeppe/set_archflags_environment_variable___for_perl_modules
comment:3 Changed 6 years ago by
- Cc jdemeyer embray vbraun added
- Commit set to 4c23c4e687ecfd7aea462583be25f82993fa52b8
- Status changed from new to needs_review
comment:4 Changed 6 years ago by
comment:5 Changed 6 years ago by
- Cc tmonteil dimpase kcrisman added
comment:6 Changed 6 years ago by
- Commit changed from 4c23c4e687ecfd7aea462583be25f82993fa52b8 to 4fce479f79408c96e3cbbaa815c9239ff833abce
comment:7 Changed 6 years ago by
Needs review.
comment:8 Changed 6 years ago by
It looks OK on Linux; must it be tested on OSX too?
comment:9 Changed 6 years ago by
I have tested it on both platforms.
comment:10 Changed 6 years ago by
put in this, and then tried to install polymake on OSX, and got
[polymake-3.0r2] checking fink installation ... The Fink package system is a mandatory prerequisite to build and use polymake under MacOS. [polymake-3.0r2] Please refer to http://www.polymake.org/doku.php/mac for details and installation instructions. [polymake-3.0r2] If you already have Fink installed at a non-standard location, please specify it using option --with-fink [polymake-3.0r2] Error configuring Polymake
Really? Fink?
comment:11 Changed 6 years ago by
- Commit changed from 4fce479f79408c96e3cbbaa815c9239ff833abce to 78f2cfacf1eefc11f60871f2874e6cfd08a1671e
Branch pushed to git repo; I updated commit sha1. New commits:
78f2cfa | Restore --without-fink that was lost
|
comment:12 Changed 6 years ago by
Thanks for catching this -- I killed the --without-fink
by accident. Should work now.
comment:13 Changed 6 years ago by
- Status changed from needs_review to positive_review
OK, looks good now.
comment:15 Changed 6 years ago by
- Reviewers set to Dima Pasechnik
- Status changed from needs_work to positive_review
comment:16 Changed 6 years ago by
- Branch changed from u/mkoeppe/set_archflags_environment_variable___for_perl_modules to 78f2cfacf1eefc11f60871f2874e6cfd08a1671e
- Resolution set to fixed
- Status changed from positive_review to closed
comment:17 Changed 2 years ago by
- Commit 78f2cfacf1eefc11f60871f2874e6cfd08a1671e deleted
Follow-up in #29408
New commits:
Set ARCHFLAGS on Darwin
perl_term_readline_gnu: Don't set ARCHFLAGS, use global setting