#21168 closed enhancement (fixed)

change_ring function for algebraic curves

Reported by: gjorgenson Owned by:
Priority: minor Milestone: sage-7.3
Component: algebraic geometry Keywords: gsoc2016
Cc: bhutz, mmarco Merged in:
Authors: Grayson Jorgenson Reviewers: Ben Hutz
Report Upstream: N/A Work issues:
Branch: e4ea51e (Commits) Commit: e4ea51ed597705e4bf5d7015df020371402da2cd
Dependencies: Stopgaps:

Description (last modified by gjorgenson)

Implement a change_ring function for algebraic curves.

Change History (5)

comment:1 Changed 23 months ago by gjorgenson

  • Branch set to u/gjorgenson/ticket/21168

comment:2 Changed 23 months ago by git

  • Commit set to e4ea51ed597705e4bf5d7015df020371402da2cd

Branch pushed to git repo; I updated commit sha1. New commits:

e4ea51e21168: change_ring implementation

comment:3 Changed 23 months ago by gjorgenson

  • Description modified (diff)
  • Status changed from new to needs_review

It looks like it's faster to duplicate the code of the subscheme implementation of change_ring than it is to just create a curve object from the subscheme implementation (which would require the initialization of two objects instead of just one).

comment:4 Changed 23 months ago by bhutz

  • Reviewers set to Ben Hutz
  • Status changed from needs_review to positive_review

This looks fine and passes all test.

comment:5 Changed 23 months ago by vbraun

  • Branch changed from u/gjorgenson/ticket/21168 to e4ea51ed597705e4bf5d7015df020371402da2cd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.