#21167 closed defect (fixed)

Bug with conversion of Singular rings to Sage rings

Reported by: gjorgenson Owned by:
Priority: minor Milestone: sage-7.4
Component: interfaces Keywords:
Cc: bhutz, mmarco Merged in:
Authors: Grayson Jorgenson Reviewers: Ben Hutz
Report Upstream: N/A Work issues:
Branch: 3ff6dc0 (Commits) Commit: 3ff6dc0df3661595edc2cd1cf7b395f1619a96b6
Dependencies: Stopgaps:


Currently there is a bug with converting Singular polynomial rings defined over field extensions to Sage polynomial rings:

R.<x,y> = PolynomialRing(QuadraticField(-1), 2)
S = R._singular_()

Change History (5)

comment:1 Changed 23 months ago by gjorgenson

  • Branch set to u/gjorgenson/ticket/21167

comment:2 Changed 23 months ago by git

  • Commit set to 3ff6dc0df3661595edc2cd1cf7b395f1619a96b6

Branch pushed to git repo; I updated commit sha1. New commits:

3ff6dc021167: fix bug and add example

comment:3 Changed 23 months ago by gjorgenson

  • Status changed from new to needs_review

Okay, I made the minor change in the sage_global_ring function and added an example demonstrating the fix. I ran some doctests and this change doesn't appear to break anything.

comment:4 Changed 23 months ago by bhutz

  • Milestone changed from sage-7.3 to sage-7.4
  • Reviewers set to Ben Hutz
  • Status changed from needs_review to positive_review

yes, this looks like the right fix.

comment:5 Changed 23 months ago by vbraun

  • Branch changed from u/gjorgenson/ticket/21167 to 3ff6dc0df3661595edc2cd1cf7b395f1619a96b6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.