Opened 5 years ago

Closed 5 years ago

#21157 closed enhancement (fixed)

Improvements to systematic encoder for linear codes

Reported by: jsrn Owned by:
Priority: major Milestone: sage-7.3
Component: coding theory Keywords: linear code
Cc: dlucas Merged in:
Authors: Johan Rosenkilde Reviewers: David Lucas
Report Upstream: N/A Work issues:
Branch: e46b9ff (Commits, GitHub, GitLab) Commit: e46b9ffdd946ef544ada452c034322f18ebf4b7c
Dependencies: #20835 Stopgaps:

Status badges

Description

#20835 introduced a systematic encoder for linear codes which always obtains as the systematic positions the lexicographically minimal possibility. It would be nice if the user could specify the systematic positions.

At the same time, one could improve some methods of AbstractLinearCode to take advantage of the new improved systematic capabilities.

Change History (6)

comment:1 Changed 5 years ago by jsrn

  • Branch set to u/jsrn/21157_improved_systematic

comment:2 Changed 5 years ago by jsrn

  • Commit set to e46b9ffdd946ef544ada452c034322f18ebf4b7c
  • Component changed from PLEASE CHANGE to coding theory
  • Keywords code added; cod removed
  • Status changed from new to needs_review

I've implemented the systematic encoder improvements as well as employed the new capabilities to simplify a few methods in AbstractLinearCode.


Last 10 new commits:

3a2f5acFixes to LinearCodeSystematicEncoder doc
a8a37bdImplement optional systematic positions + examples
084fcc4Fixed bug. Added example/test for non-information set systematic_positions
11a0e31Shortcut with AbstractLinearCode.systematic_generator_matrix
e26a379information_set can use systematic encoder
9e80364Added is_information_set
4d56371Simplified permuted_code (noticed in passing, nothing to do with systematic)
bc6b129Simplified redundancy_matrix and improved its documentation
6882f91Massively simplified AbstractLinearCode.standard_form and improved its doc
e46b9ffSmall doc improvements

comment:3 Changed 5 years ago by dlucas

  • Dependencies set to #20835
  • Status changed from needs_review to positive_review

Hello,

Tests pass and documentation builds, and you made nice improvements (included a few I was about to open a ticket for, like the improvement to redundancy_matrix's doc :)).

I give this ticket a positive review.

David

comment:4 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name is missing

comment:5 Changed 5 years ago by dlucas

  • Reviewers set to David Lucas
  • Status changed from needs_work to positive_review

Sorry...

Done now.

David

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/jsrn/21157_improved_systematic to e46b9ffdd946ef544ada452c034322f18ebf4b7c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.