Opened 6 years ago
Closed 6 years ago
#21153 closed enhancement (fixed)
Remove "But we can check that it is indeed provided by the Magmas category" doctest
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.3 |
Component: | categories | Keywords: | |
Cc: | nthiery | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | Nicolas M. Thiéry |
Report Upstream: | N/A | Work issues: | |
Branch: | 0a44b08 (Commits, GitHub, GitLab) | Commit: | 0a44b082f08c742fbe564c5afdd2f7309fabbb52 |
Dependencies: | Stopgaps: |
Description
Remove this example which will break in #20767.
Change History (7)
comment:1 Changed 6 years ago by
- Branch set to u/jdemeyer/remove__but_we_can_check_that_it_is_indeed_provided_by_the_magmas_category__doctest
comment:2 Changed 6 years ago by
- Commit set to 0a44b082f08c742fbe564c5afdd2f7309fabbb52
- Status changed from new to needs_review
comment:3 follow-up: ↓ 5 Changed 6 years ago by
comment:4 Changed 6 years ago by
- Reviewers set to Nicolas M. Thiéry
- Status changed from needs_review to positive_review
comment:5 in reply to: ↑ 3 ; follow-up: ↓ 6 Changed 6 years ago by
Replying to nthiery:
It's fine with me to remove this doctest either here or directly in #20767. The doctest just above will probably need to be changed too in #20767, right?
No, because that's _mul_parent
which is still in coercion_methods.pyx
.
If you prefer to keep this change in this separate ticket, you can set a positive review on my behalf.
Done. At this point I have a working #20767 but I'm trying to split off non-essential parts like this to make the review easier.
comment:6 in reply to: ↑ 5 Changed 6 years ago by
comment:7 Changed 6 years ago by
- Branch changed from u/jdemeyer/remove__but_we_can_check_that_it_is_indeed_provided_by_the_magmas_category__doctest to 0a44b082f08c742fbe564c5afdd2f7309fabbb52
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Remove one doctest for __mul__