Opened 7 years ago
Closed 7 years ago
#21150 closed enhancement (fixed)
py3 imports using six for StringIO and cStringIO
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.3 |
Component: | python3 | Keywords: | |
Cc: | tscrim, embray, jdemeyer, aapitzsch | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 367f931 (Commits, GitHub, GitLab) | Commit: | 367f9313640cad2b4e1d57cfe60be8f29c05c651 |
Dependencies: | Stopgaps: |
Description
as another step towards python3
part of #16069
Change History (8)
comment:1 Changed 7 years ago by
Branch: | → public/21150 |
---|---|
Commit: | → 742bf2d4fd2ead81eb904cdd81903750bc03637e |
comment:2 Changed 7 years ago by
Commit: | 742bf2d4fd2ead81eb904cdd81903750bc03637e → ac54b1a0fcb90174f8aafed7fb45970b9b37acf2 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
ac54b1a | trac 21150 adding absolute_import in explain_pickle
|
comment:3 Changed 7 years ago by
Cc: | tscrim embray jdemeyer aapitzsch added |
---|---|
Status: | new → needs_review |
bot is green, please review
comment:4 Changed 7 years ago by
Reviewers: | → Travis Scrimshaw |
---|
If you are going to change if len(L) > 0:
, then you might as well change it to the faster if L:
. Otherwise LGTM.
comment:5 Changed 7 years ago by
Commit: | ac54b1a0fcb90174f8aafed7fb45970b9b37acf2 → 367f9313640cad2b4e1d57cfe60be8f29c05c651 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
367f931 | trac #21150 detail
|
comment:8 Changed 7 years ago by
Branch: | public/21150 → 367f9313640cad2b4e1d57cfe60be8f29c05c651 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
py3 imports for StringIO and cStringIO