Opened 5 years ago

Closed 5 years ago

#21143 closed enhancement (fixed)

new style package for qhull

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-7.4
Component: packages: optional Keywords:
Cc: Merged in:
Authors: Vincent Delecroix Reviewers: Matthias Koeppe
Report Upstream: Reported upstream. Developers acknowledge bug. Work issues:
Branch: 6fc873d (Commits, GitHub, GitLab) Commit: 6fc873d902fd47ceb2e7ca48f7b4c05319c5ab06
Dependencies: Stopgaps:

Status badges

Description (last modified by vdelecroix)

The branch turns qhull into a new style package (and updates it to the most recent version).

Upstream tarball at

http://www.qhull.org/download/qhull-2015-src-7.2.0.tgz

see also: #19220

Change History (14)

comment:1 Changed 5 years ago by vdelecroix

  • Description modified (diff)

comment:2 Changed 5 years ago by vdelecroix

  • Branch set to u/vdelecroix/21143
  • Commit set to 20af0fc096dd82aa0280b390a3e93f331e2da39d
  • Status changed from new to needs_review

New commits:

20af0fc21143: new style package for qhull

comment:3 Changed 5 years ago by git

  • Commit changed from 20af0fc096dd82aa0280b390a3e93f331e2da39d to fcc68c5d8ed34bfbab325c0b9155f2695faf6113

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

fcc68c521143: new style package for qhull

comment:4 Changed 5 years ago by vdelecroix

  • Report Upstream changed from N/A to Reported upstream. No feedback yet.

(I reported upstream with respect to the patch)

comment:5 follow-up: Changed 5 years ago by mkoeppe

It builds fine for me on Mac OS X.

An answer to an Ask SageMath question here claims that qhull is included with scipy: http://ask.sagemath.org/question/10254/how-does-one-use-the-qhull-optional-package/

Also there is this ticket: https://trac.sagemath.org/ticket/12352

comment:6 in reply to: ↑ 5 ; follow-up: Changed 5 years ago by vdelecroix

Replying to mkoeppe:

It builds fine for me on Mac OS X.

An answer to an Ask SageMath question here claims that qhull is included with scipy: http://ask.sagemath.org/question/10254/how-does-one-use-the-qhull-optional-package/

Indeed

But scipy does not seem to ship the binaries... But however their interface is pretty good and that's actually what we should use!

Also there is this ticket: https://trac.sagemath.org/ticket/12352

which is rather disjoint.

comment:7 in reply to: ↑ 6 Changed 5 years ago by mkoeppe

Replying to vdelecroix:

Replying to mkoeppe:

It builds fine for me on Mac OS X.

An answer to an Ask SageMath question here claims that qhull is included with scipy: http://ask.sagemath.org/question/10254/how-does-one-use-the-qhull-optional-package/

Indeed

But scipy does not seem to ship the binaries... But however their interface is pretty good and that's actually what we should use!

Right, for polymake (#20892) we do need the binaries. Could you update the SPKG.txt to include info about scipy?

comment:8 Changed 5 years ago by git

  • Commit changed from fcc68c5d8ed34bfbab325c0b9155f2695faf6113 to 6fc873d902fd47ceb2e7ca48f7b4c05319c5ab06

Branch pushed to git repo; I updated commit sha1. New commits:

6fc873d21143: mention scipy and Pyhull in SPKG.txt

comment:9 Changed 5 years ago by vdelecroix

done

comment:10 Changed 5 years ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:11 Changed 5 years ago by vdelecroix

Thanks!

comment:12 Changed 5 years ago by vdelecroix

  • Milestone changed from sage-7.3 to sage-7.4

comment:13 Changed 5 years ago by vdelecroix

  • Report Upstream changed from Reported upstream. No feedback yet. to Reported upstream. Developers acknowledge bug.

for info: got a reply from upstream (Brad Barber). The next version of the Makefile will contain the target dependencies and there will be a configurable make install. However, it seems hard to get a configure to work on all platforms...

comment:14 Changed 5 years ago by vbraun

  • Branch changed from u/vdelecroix/21143 to 6fc873d902fd47ceb2e7ca48f7b4c05319c5ab06
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.