Remove redundant _lmul_ and _rmul_ methods
| Reported by: |
jdemeyer |
Owned by: |
|
|
Priority:
|
major
|
Milestone:
|
sage-7.3
|
|
Component:
|
coercion
|
Keywords:
|
|
|
Cc:
|
|
Merged in:
|
|
|
Authors:
|
Jeroen Demeyer
|
Reviewers:
|
Vincent Delecroix
|
|
Report Upstream:
|
N/A
|
Work issues:
|
|
|
Branch:
|
69d18c7 (Commits, GitHub, GitLab) |
Commit:
|
69d18c75875c8a9f770e9ef493d6e721854f4448
|
|
Dependencies:
|
|
Stopgaps:
|
|
- Assume commutativity by default and implement
_rmul_ as falling back to _lmul_ (like we already do for AdditiveGroupElement).
- Implement the basic
_lmul_ and _rmul_ just once in ModuleElement: remove the redundant implementations from RingElement and AdditiveGroupElement.
Change History (6)
| Description: |
modified (diff)
|
| Summary: |
Remove redundant _lmul_ and _rmul_ →
Remove redundant _lmul_ and _rmul_ methods
|
| Branch: |
→ u/jdemeyer/remove_redundant__lmul__and__rmul__methods
|
| Commit: |
→ 69d18c75875c8a9f770e9ef493d6e721854f4448
|
| Status: |
new →
needs_review
|
| Reviewers: |
→ Vincent Delecroix
|
| Status: |
needs_review →
positive_review
|
| Branch: |
u/jdemeyer/remove_redundant__lmul__and__rmul__methods →
69d18c75875c8a9f770e9ef493d6e721854f4448
|
| Resolution: |
→ fixed
|
| Status: |
positive_review →
closed
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
Remove redundant _lmul_ and _rmul_ methods