Opened 5 years ago

Closed 5 years ago

#21140 closed enhancement (fixed)

Remove redundant _lmul_ and _rmul_ methods

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.3
Component: coercion Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 69d18c7 (Commits, GitHub, GitLab) Commit: 69d18c75875c8a9f770e9ef493d6e721854f4448
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

  1. Assume commutativity by default and implement _rmul_ as falling back to _lmul_ (like we already do for AdditiveGroupElement).
  1. Implement the basic _lmul_ and _rmul_ just once in ModuleElement: remove the redundant implementations from RingElement and AdditiveGroupElement.

Change History (6)

comment:1 Changed 5 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Remove redundant _lmul_ and _rmul_ to Remove redundant _lmul_ and _rmul_ methods

comment:2 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/remove_redundant__lmul__and__rmul__methods

comment:3 Changed 5 years ago by git

  • Commit set to 69d18c75875c8a9f770e9ef493d6e721854f4448

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​69d18c7Remove redundant _lmul_ and _rmul_ methods

comment:4 Changed 5 years ago by jdemeyer

  • Status changed from new to needs_review

comment:5 Changed 5 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/remove_redundant__lmul__and__rmul__methods to 69d18c75875c8a9f770e9ef493d6e721854f4448
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.