Opened 10 months ago
Closed 10 months ago
#21137 closed enhancement (fixed)
Rational parameterizations for rational curves
Reported by:  gjorgenson  Owned by:  

Priority:  minor  Milestone:  sage7.3 
Component:  algebraic geometry  Keywords:  gsoc2016 
Cc:  bhutz, mmarco  Merged in:  
Authors:  Grayson Jorgenson  Reviewers:  Ben Hutz 
Report Upstream:  N/A  Work issues:  
Branch:  1080efc (Commits)  Commit:  1080efcf87969c05765af965b4ed0a00be97d366 
Dependencies:  #21167, #21168  Stopgaps: 
Description
Implement a function to compute rational parameterizations for rational (genus 0) projective plane curves using Singular. If possible, use this to create a version of the function for rational affine plane curves.
Change History (9)
comment:1 Changed 10 months ago by
 Branch set to u/gjorgenson/ticket/21137
comment:2 Changed 10 months ago by
 Commit set to db914fcad7df493f239a4584ed8564b866eeb946
comment:3 Changed 10 months ago by
 Commit changed from db914fcad7df493f239a4584ed8564b866eeb946 to a68f3e9512ad6475a5a5e076e617793276bd00a1
Branch pushed to git repo; I updated commit sha1. New commits:
0057656  21137: parameterizations now given as birational maps

27a91b5  Merge branch 'master' into u/gjorgenson/ticket/21137

3ff6dc0  21167: fix bug and add example

211aaac  21137: merge with ticket 21167

e4ea51e  21168: change_ring implementation

f82e30e  21137: merge with ticket 21168

a68f3e9  21137: support for parameterizations defined over quadratic field extensions of QQ

comment:4 Changed 10 months ago by
 Dependencies set to #21167, #21168
 Status changed from new to needs_review
comment:5 Changed 10 months ago by
 Reviewers set to Ben Hutz
 Status changed from needs_review to needs_work
This seems fine to me. I tried a couple additional examples which worked. The only thing I'd change is in change_ring: 'morphism' > 'embedding' is the inputs.
comment:6 Changed 10 months ago by
 Commit changed from a68f3e9512ad6475a5a5e076e617793276bd00a1 to 1080efcf87969c05765af965b4ed0a00be97d366
Branch pushed to git repo; I updated commit sha1. New commits:
1080efc  21137: minor doc change

comment:7 Changed 10 months ago by
 Status changed from needs_work to needs_review
comment:8 Changed 10 months ago by
 Status changed from needs_review to positive_review
comment:9 Changed 10 months ago by
 Branch changed from u/gjorgenson/ticket/21137 to 1080efcf87969c05765af965b4ed0a00be97d366
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. New commits:
21137: implemented projective/affine rational parameterization functions