Changes between Initial Version and Version 1 of Ticket #21135, comment 37


Ignore:
Timestamp:
08/19/16 15:14:59 (5 years ago)
Author:
dimpase
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21135, comment 37

    initial v1  
    99
    1010
     11> Could we please have something reviewable, useable (= allowing for {{{make ptestlong}}} to succeed when checking something else...) and dispatch aesthetic //disputationes// to another ticket ?
    1112
    12 >
    13 > FYI, the following diff (a four-letters patch...) against the current (7.4beta1) sage is **sufficient** to have sage passing the tests for external interfaces :
    14 >
    15 > {{{
    16 > diff --git a/src/sage/interfaces/octave.py b/src/sage/interfaces/octave.py
    17 > index cfbbceb..5b2ce36 100644
    18 > --- a/src/sage/interfaces/octave.py
    19 > +++ b/src/sage/interfaces/octave.py
    20 > @@ -184,7 +184,7 @@ class Octave(Expect):
    21 >          Expect.__init__(self,
    22 >                          name = 'octave',
    23 >                          prompt = '>',
    24 > -                        command = "sage-native-execute octave --no-line-editing --silent",
    25 > +                        command = "sage-native-execute octave-cli --no-line-editing --silent",
    26 >                          server = server,
    27 >                          server_tmpdir = server_tmpdir,
    28 >                          script_subdirectory = script_subdirectory,
    29 > }}}
    30 >
    31 > Proof (I wanted to check fricas 1.2.7 before reviewing #21231) :
    32 >
    33 > {{{
    34 > charpent@SAP5057241:/usr/local/sage-7$ sage -t --optional=sage,octave,fricas $(sage -root)/src/sage/doctest/external.py
    35 > Running doctests with ID 2016-08-19-16-01-10-87c81a5b.
    36 > Git branch: quickoctavefix
    37 > Using --optional=fricas,octave,sage
    38 > Doctesting 1 file.
    39 > sage -t --warn-long 70.0 src/sage/doctest/external.py
    40 >     [38 tests, 38.24 s]
    41 > ----------------------------------------------------------------------
    42 > All tests passed!
    43 > ----------------------------------------------------------------------
    44 > Total time for all tests: 38.3 seconds
    45 >     cpu time: 0.6 seconds
    46 >     cumulative wall time: 38.2 seconds
    47 > }}}
    48 >
    49 > Could we please have something reviewable, useable (= allowing for {{{make ptestlong}}} to succeed when checking something else...) and dispatch aesthetic //disputationes// to another ticket ?
     13Well, does this branch actually work for you? If not, I would like to know which  test it fails, and the version of octave.