Opened 6 years ago

Last modified 8 weeks ago

#21129 needs_review enhancement

Arakelov-Zhang pairing of rational maps

Reported by: paulfili Owned by:
Priority: minor Milestone: sage-9.7
Component: dynamics Keywords: sd104
Cc: hkrieger, gh-yuankmath Merged in:
Authors: Paul Fili, Holly Krieger Reviewers:
Report Upstream: N/A Work issues:
Branch: u/paulfili/AZpairing (Commits, GitHub, GitLab) Commit: 2a8b393878cdf2162816f502a681d0aa944cfb94
Dependencies: 28779 Stopgaps:

Status badges

Description

We add a function to compute the dynamical Arakelov-Zhang pairing of two rational maps defined over number fields.

Change History (25)

comment:1 Changed 6 years ago by paulfili

  • Branch set to u/paulfili/arakelov_zhang_pairing_of_rational_maps

comment:2 Changed 6 years ago by paulfili

  • Cc hkrieger added
  • Commit set to a6cca7c9827e746d49cc0d1bbd44eb3bc9fab2e2
  • Status changed from new to needs_review

comment:3 Changed 6 years ago by git

  • Commit changed from a6cca7c9827e746d49cc0d1bbd44eb3bc9fab2e2 to b3ea8584f52d9355629c4f82f6495a5aff3e742a

Branch pushed to git repo; I updated commit sha1. New commits:

​b3ea858Fixed an error in use of default precision of RealField

comment:4 Changed 6 years ago by git

  • Commit changed from b3ea8584f52d9355629c4f82f6495a5aff3e742a to ec5eac2de69f479e86d087b38d7b6bb95b0fe4b9

Branch pushed to git repo; I updated commit sha1. New commits:

​ec5eac221129: added a needed import statement

comment:5 Changed 5 years ago by chapoton

please use python3-compatible syntax for print (see ​https://wiki.sagemath.org/Python3-compatible%20code)

comment:6 Changed 5 years ago by chapoton

plus one failing doctest, see patchbot report

comment:7 Changed 5 years ago by chapoton

  • Branch changed from u/paulfili/arakelov_zhang_pairing_of_rational_maps to public/arakelov_zhang
  • Commit changed from ec5eac2de69f479e86d087b38d7b6bb95b0fe4b9 to 6ab8e9166ab907d94cbfd3b7be4612828587d26a

I removed the bad prints and corrected the failing doctest.

New commits:

​a3bfe9cMerge branch 'u/paulfili/arakelov_zhang_pairing_of_rational_maps' in 8.0.rc2
​6ab8e91trac 21129 fixing details

comment:8 Changed 5 years ago by chapoton

  • Milestone changed from sage-7.4 to sage-8.1
  • Summary changed from arakelov-zhang pairing of rational maps to Arakelov-Zhang pairing of rational maps

comment:9 Changed 5 years ago by bhutz

  • Component changed from algebraic geometry to dynamics

comment:10 Changed 5 years ago by chapoton

  • Status changed from needs_review to needs_work

comment:11 Changed 3 years ago by gh-yuankmath

  • Branch changed from public/arakelov_zhang to u/gh-yuankmath/AZpairing
  • Cc gh-yuankmath added
  • Commit changed from 6ab8e9166ab907d94cbfd3b7be4612828587d26a to 357a0a1829c2045be996da2c58d14b4386a8fecb
  • Milestone changed from sage-8.1 to sage-9.0

Updated to sage 9.0 codebase

New commits:

​357a0a1Updated our Arakelov_Zhang_pairing funciton

comment:12 Changed 3 years ago by git

  • Commit changed from 357a0a1829c2045be996da2c58d14b4386a8fecb to 664acad2dab27d748412876f140f0a2e6d1d484c

Branch pushed to git repo; I updated commit sha1. New commits:

​664acadUpdate Examples in Arakelov_Zhang_pairing

comment:13 Changed 3 years ago by paulfili

  • Dependencies set to 28779
  • Keywords sd104 added

There is currently a bug in prime_of_bad_reduction, reported now in #28779, which affects one of the examples here. (Apparently the bug wasn't present when the examples were first computed!). I'd rather not remove a good example, so we are marking this as dependent on that bug fix.

comment:14 Changed 3 years ago by paulfili

  • Status changed from needs_work to needs_review

The bug in #28779 should be fixed. If you apply that patch, then this one, it should now be working.

comment:15 follow-up: Changed 3 years ago by bhutz

notice that this is listed as 13000 lines of code change. It looks like git thinks you've deleted the entire file and re-written it. It would be better not to lose the code change history. Can you see if you can get it to just have your changes?

comment:16 Changed 3 years ago by paulfili

  • Branch changed from u/gh-yuankmath/AZpairing to u/paulfili/AZpairing

comment:17 in reply to: ↑ 15 Changed 3 years ago by paulfili

  • Commit changed from 664acad2dab27d748412876f140f0a2e6d1d484c to 2a8b393878cdf2162816f502a681d0aa944cfb94

Replying to bhutz:

notice that this is listed as 13000 lines of code change. It looks like git thinks you've deleted the entire file and re-written it. It would be better not to lose the code change history. Can you see if you can get it to just have your changes?

Done!

New commits:

​ba813c7Added Arakelov Zhang pairing function to fresh copy of projective_ds.py
​0c4e9b2Fixed error, clears LCM of denominators always, GCD as appropriate
​2778cdbMerge branch 'u/paulfili/normalize' of git://trac.sagemath.org/sage into azpairing
​2a8b393Updated AZ pairing and checked tests

comment:18 Changed 3 years ago by bhutz

Thanks!

comment:19 Changed 2 years ago by embray

  • Milestone changed from sage-9.0 to sage-9.1

Ticket retargeted after milestone closed

comment:20 Changed 2 years ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-9.2

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

comment:21 Changed 21 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:22 Changed 15 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:23 Changed 10 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5

Setting a new milestone for this ticket based on a cursory review.

comment:24 Changed 5 months ago by mkoeppe

  • Milestone changed from sage-9.5 to sage-9.6

Stalled in needs_review or needs_info; likely won't make it into Sage 9.5.

comment:25 Changed 8 weeks ago by mkoeppe

  • Milestone changed from sage-9.6 to sage-9.7
Note: See TracTickets for help on using tickets.