Opened 6 years ago

Closed 6 years ago

#21126 closed defect (fixed)

Add two Cython fixes

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.4
Component: packages: standard Keywords:
Cc: robertwb Merged in:
Authors: Jeroen Demeyer Reviewers: Nicolas M. Thiéry
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: 24bc354 (Commits, GitHub, GitLab) Commit: 24bc354a7a8d41e35b0f617ecc9fcfd2c3f6143d
Dependencies: Stopgaps:

Status badges

Description (last modified by nthiery)

See:

Change History (14)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/add_a_cython_fix_for_cpdef_methods

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to 093395e146c84a55a00ae0fcbb3b5eb9ee8915f4
  • Status changed from new to needs_review

New commits:

093395eAdd a Cython fix for cpdef methods

comment:3 Changed 6 years ago by jdemeyer

  • Cc robertwb added

comment:4 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from needs_review to needs_work
  • Summary changed from Add a Cython fix for cpdef methods to Add two Cython fixes

comment:5 Changed 6 years ago by git

  • Commit changed from 093395e146c84a55a00ae0fcbb3b5eb9ee8915f4 to aa02833f3a58efea9a09dd23f364d4ccbc6ebe21

Branch pushed to git repo; I updated commit sha1. New commits:

aa02833Fix Cython gdb debugging

comment:6 Changed 6 years ago by git

  • Commit changed from aa02833f3a58efea9a09dd23f364d4ccbc6ebe21 to 24bc354a7a8d41e35b0f617ecc9fcfd2c3f6143d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

24bc354Fix Cython gdb debugging

comment:7 Changed 6 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:8 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:9 Changed 6 years ago by nthiery

  • Description modified (diff)

comment:10 Changed 6 years ago by nthiery

  • Description modified (diff)

+1 on merging this as soon as Cython' PR #545 is merged. I did a ping on this PR.

comment:11 Changed 6 years ago by nthiery

  • Status changed from needs_review to positive_review

Robert just merged the PR. So positive review!

Thanks Robert :-)

comment:12 Changed 6 years ago by nthiery

  • Description modified (diff)
  • Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.

comment:13 Changed 6 years ago by nthiery

  • Reviewers set to Nicolas M. Thiéry

comment:14 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/add_a_cython_fix_for_cpdef_methods to 24bc354a7a8d41e35b0f617ecc9fcfd2c3f6143d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.