Opened 4 years ago

Closed 4 years ago

#21113 closed defect (fixed)

unflattening morphim error

Reported by: bhutz Owned by:
Priority: minor Milestone: sage-7.4
Component: algebra Keywords:
Cc: vdelecroix Merged in:
Authors: Ben Hutz Reviewers: Vincent Delecroix, Paul Fili
Report Upstream: N/A Work issues:
Branch: 4b083ad (Commits) Commit: 4b083ad410d074dd83c1f49a7b2efb4073f02e41
Dependencies: #21106 Stopgaps:

Description (last modified by vdelecroix)

UnflatteningMorphism cannot be used by itself since the attribute _intermediate rings is defined through the method section of FlatteningMorphism.

Change History (8)

comment:1 Changed 4 years ago by bhutz

  • Branch set to u/bhutz/unflattening

comment:2 Changed 4 years ago by bhutz

  • Cc vdelecroix added
  • Commit set to ed45887e99409482a501019bd48e2761114ab7f1
  • Status changed from new to needs_review

New commits:

cf97fed21106: create polynomial ring flattening class
957589f21106: minor fixes
8c22f7521106: new version of _call_
570d9ee21106: added doc tests
6e5094221106: change file mode
19cb17121106: Python3 compatibility + more cleaning
ed4588721113: add init for UnflatteningMorphism

comment:3 Changed 4 years ago by vdelecroix

  • Dependencies set to #21106
  • Description modified (diff)
  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to needs_work

It would be good to check (and doctest) that:

  • domain is a MPolynomialRing
  • that the base ring of domain is the base ring of the last element of intermediate_ring
  • that the number of variables match

comment:4 Changed 4 years ago by git

  • Commit changed from ed45887e99409482a501019bd48e2761114ab7f1 to 211ea034d8b4219e9a5445f5778c4bc2a08dd6a2

Branch pushed to git repo; I updated commit sha1. New commits:

211ea0321113: add input checks

comment:5 Changed 4 years ago by bhutz

  • Authors set to Ben Hutz
  • Status changed from needs_work to needs_review

comment:6 Changed 4 years ago by paulfili

  • Branch changed from u/bhutz/unflattening to u/paulfili/unflattening

comment:7 Changed 4 years ago by paulfili

  • Commit changed from 211ea034d8b4219e9a5445f5778c4bc2a08dd6a2 to 4b083ad410d074dd83c1f49a7b2efb4073f02e41
  • Milestone changed from sage-7.3 to sage-7.4
  • Reviewers changed from Vincent Delecroix to Vincent Delecroix, Paul Fili
  • Status changed from needs_review to positive_review

New commits:

4b083ad21113: corrected one typographical error

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/paulfili/unflattening to 4b083ad410d074dd83c1f49a7b2efb4073f02e41
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.