Opened 2 years ago
Closed 2 years ago
#21099 closed enhancement (fixed)
critical subscheme / critical points for a map on projective space
Reported by:  mmanes  Owned by:  

Priority:  minor  Milestone:  sage7.4 
Component:  algebraic geometry  Keywords:  
Cc:  Merged in:  
Authors:  Michelle Manes  Reviewers:  Holly Krieger, Ben Hutz 
Report Upstream:  N/A  Work issues:  
Branch:  ef2199e (Commits)  Commit:  ef2199e88364e3523271c884c595e325ce300b1f 
Dependencies:  Stopgaps: 
Description (last modified by )
Create function to compute the critical subscheme of a function on projective space.
Edit critical_points to use this function rather than reproducing the code.
Change History (12)
comment:1 Changed 2 years ago by
 Description modified (diff)
 Summary changed from critical subscheme for a map on projective space to critical subscheme / critical points for a map on projective space
comment:2 Changed 2 years ago by
 Branch set to u/mmanes/critical_subscheme___critical_points_for_a_map_on_projective_space
comment:3 Changed 2 years ago by
 Commit set to 7affa56c71846ecb2c2a79afbd1df05098e306e7
 Status changed from new to needs_review
comment:4 followup: ↓ 6 Changed 2 years ago by
You claim in the doc
+ INPUT: + +  ``R``  a ring (optional).
but there is no argument to your function...
comment:5 Changed 2 years ago by
 Commit changed from 7affa56c71846ecb2c2a79afbd1df05098e306e7 to c98c48906ca76d6c7678a9594cb497e98e20630b
Branch pushed to git repo; I updated commit sha1. New commits:
c98c489  20199: removed "INPUT" line that isn't used

comment:6 in reply to: ↑ 4 Changed 2 years ago by
Thanks! Removed that.
Replying to vdelecroix:
You claim in the doc
+ INPUT: + +  ``R``  a ring (optional).but there is no argument to your function...
comment:7 Changed 2 years ago by
 Reviewers set to Holly Krieger
 Status changed from needs_review to needs_work
The function accepts nonmorphisms and should probably not.
set_verbose(None) P.<x,y> = ProjectiveSpace(QQ,1) H = End(P) f = H([x^2,x*y]) f.critical_subscheme()
comment:8 Changed 2 years ago by
 Commit changed from c98c48906ca76d6c7678a9594cb497e98e20630b to ef2199e88364e3523271c884c595e325ce300b1f
Branch pushed to git repo; I updated commit sha1. New commits:
ef2199e  21099: added check that object is a morphism

comment:9 Changed 2 years ago by
 Status changed from needs_work to needs_review
Fixes from last review added. critical_subscheme now checks that the object is a morphism example added to document this
comment:10 Changed 2 years ago by
 Milestone changed from sage7.3 to sage7.4
comment:11 Changed 2 years ago by
 Reviewers changed from Holly Krieger to Holly Krieger, Ben Hutz
 Status changed from needs_review to positive_review
looks fine
comment:12 Changed 2 years ago by
 Branch changed from u/mmanes/critical_subscheme___critical_points_for_a_map_on_projective_space to ef2199e88364e3523271c884c595e325ce300b1f
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
21099: implement critical_subscheme