Opened 5 years ago

Closed 4 years ago

#21087 closed enhancement (fixed)

new style package for sip

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-7.3
Component: packages: optional Keywords:
Cc: jdemeyer, vbraun Merged in:
Authors: Vincent Delecroix Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: e9e59a5 (Commits, GitHub, GitLab) Commit: e9e59a508de9975ff2083d98714bde6e6b250246
Dependencies: Stopgaps:

Status badges

Description (last modified by vdelecroix)

Upstream tarball

​http://sourceforge.net/projects/pyqt/files/sip/sip-4.18/sip-4.18.tar.gz

Change History (14)

comment:1 Changed 5 years ago by vdelecroix

  • Branch set to u/vdelecroix/21087
  • Cc jdemeyer vbraun added
  • Commit set to 777b4ecbc01082cf18062e6aefdfb678d6d13194

New commits:

​777b4ecTrac 21087: make sip a new style package

comment:2 Changed 5 years ago by vdelecroix

  • Description modified (diff)

comment:3 in reply to: ↑ description Changed 5 years ago by jdemeyer

Replying to vdelecroix:

Note that sip requires flex and bison...

Are you sure? The README says 

If you are using a copy of SIP cloned from the Mercurial repository, or are
using a Mercurial archive, then you have to prepare it first before you follow
the normal installation instructions.

The preparation is done using the ``build.py`` script which can be found in the
same directory as this ``README`` file.  If it isn't there then you probably
have a packaged release and should just follow the normal installation
instructions.

The ``build.py`` script requires that ``flex`` and ``bison``, and the Mercurial
Python bindings are installed.  If you want to create the HTML documentation
then Sphinx must also be installed.

So I understand that flex and bison are not needed for a "packaged release" (which is how it should be!).

comment:4 Changed 5 years ago by jdemeyer

  1. You need to check for errors in spkg-install.
  1. You should use $MAKE instead of make.

comment:5 Changed 5 years ago by git

  • Commit changed from 777b4ecbc01082cf18062e6aefdfb678d6d13194 to 19315aea3ab8819dfdd29467c2b46ad565f46f29

Branch pushed to git repo; I updated commit sha1. New commits:

​19315aeTrac 21087: cleaner spkg-install

comment:6 Changed 5 years ago by vdelecroix

  • Description modified (diff)
  • Status changed from new to needs_review

comment:7 Changed 5 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to needs_work

Two nitpicks:

  1. Use 4 spaces for indentation, also in spkg-install.
  1. The license can be also GPL version 2 or GPL version 3 (which is very important for Sage!)

comment:8 Changed 5 years ago by vbraun

As long as its "or later" the GPL version doesn't matter; We already have GPLv3+ dependencies.

comment:9 Changed 5 years ago by jdemeyer

It's not "or later". It's GPL version 2 or 3.

Anyway, my point is that this needs to be documented in SPKG.txt.

comment:10 Changed 5 years ago by vbraun

Well that sucks...

comment:11 Changed 5 years ago by git

  • Commit changed from 19315aea3ab8819dfdd29467c2b46ad565f46f29 to e9e59a508de9975ff2083d98714bde6e6b250246

Branch pushed to git repo; I updated commit sha1. New commits:

​65d2561Trac 21087: tab -> 4 spaces
​e9e59a5Trac 21087: license information

comment:12 Changed 5 years ago by vdelecroix

  • Status changed from needs_work to needs_review

comment:13 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:14 Changed 4 years ago by vbraun

  • Branch changed from u/vdelecroix/21087 to e9e59a508de9975ff2083d98714bde6e6b250246
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.