Opened 7 years ago
Closed 6 years ago
#21087 closed enhancement (fixed)
new style package for sip
Reported by: | vdelecroix | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.3 |
Component: | packages: optional | Keywords: | |
Cc: | jdemeyer, vbraun | Merged in: | |
Authors: | Vincent Delecroix | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | e9e59a5 (Commits, GitHub, GitLab) | Commit: | e9e59a508de9975ff2083d98714bde6e6b250246 |
Dependencies: | Stopgaps: |
Description (last modified by )
Change History (14)
comment:1 Changed 7 years ago by
Branch: | → u/vdelecroix/21087 |
---|---|
Cc: | jdemeyer vbraun added |
Commit: | → 777b4ecbc01082cf18062e6aefdfb678d6d13194 |
comment:2 Changed 7 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 7 years ago by
Replying to vdelecroix:
Note that sip requires flex and bison...
Are you sure? The README
says
If you are using a copy of SIP cloned from the Mercurial repository, or are using a Mercurial archive, then you have to prepare it first before you follow the normal installation instructions. The preparation is done using the ``build.py`` script which can be found in the same directory as this ``README`` file. If it isn't there then you probably have a packaged release and should just follow the normal installation instructions. The ``build.py`` script requires that ``flex`` and ``bison``, and the Mercurial Python bindings are installed. If you want to create the HTML documentation then Sphinx must also be installed.
So I understand that flex and bison are not needed for a "packaged release" (which is how it should be!).
comment:4 Changed 7 years ago by
- You need to check for errors in
spkg-install
.
- You should use
$MAKE
instead ofmake
.
comment:5 Changed 7 years ago by
Commit: | 777b4ecbc01082cf18062e6aefdfb678d6d13194 → 19315aea3ab8819dfdd29467c2b46ad565f46f29 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
19315ae | Trac 21087: cleaner spkg-install
|
comment:6 Changed 7 years ago by
Description: | modified (diff) |
---|---|
Status: | new → needs_review |
comment:7 Changed 7 years ago by
Reviewers: | → Jeroen Demeyer |
---|---|
Status: | needs_review → needs_work |
Two nitpicks:
- Use 4 spaces for indentation, also in
spkg-install
.
- The license can be also GPL version 2 or GPL version 3 (which is very important for Sage!)
comment:8 Changed 7 years ago by
As long as its "or later" the GPL version doesn't matter; We already have GPLv3+ dependencies.
comment:9 Changed 7 years ago by
It's not "or later". It's GPL version 2 or 3.
Anyway, my point is that this needs to be documented in SPKG.txt
.
comment:11 Changed 7 years ago by
Commit: | 19315aea3ab8819dfdd29467c2b46ad565f46f29 → e9e59a508de9975ff2083d98714bde6e6b250246 |
---|
comment:12 Changed 7 years ago by
Status: | needs_work → needs_review |
---|
comment:13 Changed 6 years ago by
Status: | needs_review → positive_review |
---|
comment:14 Changed 6 years ago by
Branch: | u/vdelecroix/21087 → e9e59a508de9975ff2083d98714bde6e6b250246 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
Trac 21087: make sip a new style package