Opened 5 years ago

Closed 4 years ago

#21066 closed defect (fixed)

Unpickle overrides for finite fields

Reported by: novoselt Owned by:
Priority: major Milestone: sage-8.0
Component: pickling Keywords:
Cc: Merged in:
Authors: Andrey Novoseltsev Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 526cc78 (Commits, GitHub, GitLab) Commit: 526cc78d4e04219c0c33d642c1ce8f5eade92b95
Dependencies: Stopgaps:

Status badges

Description

Two overrides necessary to make load('http://rlmiller.org/de_codes/get_code.php?id=16_08') work - result of using #21065

Change History (7)

comment:1 Changed 5 years ago by novoselt

  • Branch set to u/novoselt/unpickle_overrides_for_finite_fields

comment:2 Changed 5 years ago by novoselt

  • Commit set to 526cc78d4e04219c0c33d642c1ce8f5eade92b95
  • Status changed from new to needs_review

New commits:

526cc78Add two unpickle overrides for backward compatibility.

comment:3 Changed 4 years ago by tscrim

Two trivial PEP8 things:

-register_unpickle_override(
-    'sage.rings.ring', 'unpickle_FiniteField_prm', unpickle_FiniteField_prm)
+register_unpickle_override('sage.rings.ring', 'unpickle_FiniteField_prm',
+                           unpickle_FiniteField_prm)

and

-register_unpickle_override(
-    'sage.rings.finite_field_prime_modn', 'FiniteField_prime_modn',
-    FiniteField_prime_modn)
+register_unpickle_override('sage.rings.finite_field_prime_modn',
+                           'FiniteField_prime_modn', FiniteField_prime_modn)

Otherwise LGTM.

comment:4 Changed 4 years ago by tscrim

  • Milestone changed from sage-7.3 to sage-8.0
  • Reviewers set to Travis Scrimshaw

comment:5 Changed 4 years ago by novoselt

Thanks for taking a look! I am a bit confused about PEP8, it seems to me that I am using one of the acceptable formats with hanging indent: https://www.python.org/dev/peps/pep-0008/#indentation

comment:6 Changed 4 years ago by tscrim

  • Status changed from needs_review to positive_review

Ah, right, that is acceptable. I've just been using the first and thought that was the (marginally?) more preferred way. Thanks.

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/novoselt/unpickle_overrides_for_finite_fields to 526cc78d4e04219c0c33d642c1ce8f5eade92b95
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.