Opened 3 years ago

Closed 3 years ago

#21060 closed enhancement (fixed)

wrong parent for q_catalan numbers

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-7.3
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: f0d8991 (Commits) Commit: f0d8991edf668091c146dca9d54b517960d9e3cf
Dependencies: Stopgaps:

Description (last modified by tmonteil)

Shoud be the polynomial ring, not fraction field. See ​this ask question.

Change History (5)

comment:1 Changed 3 years ago by chapoton

  • Branch set to public/21060
  • Commit set to f0d8991edf668091c146dca9d54b517960d9e3cf
  • Status changed from new to needs_review

New commits:

​f0d8991trac 21060 better parent for q_catalan numbers

comment:2 Changed 3 years ago by chapoton

  • Summary changed from wrong parent for q_catalan nunmbers to wrong parent for q_catalan numbers

comment:3 Changed 3 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo
  • Status changed from needs_review to positive_review

Seems to work, so I guess I must put this to positive_review.

But I don't understand the statement "Note that even with this option, the tests within a given doctest block are still run in order." about testing in random order. Is "doctest block" a combination of EXAMPLES and TESTS in one function? I would have guessed that the test block fails for missing import statement if run before examples block.

comment:4 Changed 3 years ago by tmonteil

  • Description modified (diff)

comment:5 Changed 3 years ago by vbraun

  • Branch changed from public/21060 to f0d8991edf668091c146dca9d54b517960d9e3cf
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.