Opened 3 years ago

Closed 3 years ago

#21058 closed enhancement (fixed)

get rid of one sort using cmp in totally real fields

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: python3 Keywords:
Cc: jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: cada576 (Commits) Commit: cada576b4221a3ec794b3dfdaaaa3a4684063eed
Dependencies: Stopgaps:

Description

as a step towards python3

Change History (8)

comment:1 Changed 3 years ago by chapoton

  • Branch set to public/21058
  • Cc jdemeyer added
  • Commit set to 97e02e3cdd7c78bb28ed9060181eab7edb4ca905
  • Status changed from new to needs_review

New commits:

6fe012eremove one use of cmp in totally real fields
97e02e3explanations on the sort by discriminant only

comment:2 Changed 3 years ago by jdemeyer

  • Status changed from needs_review to needs_work

I think it's better to replace

     S = [...]
     S.sort()

by

     S = sorted(...)

comment:4 Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer

comment:5 Changed 3 years ago by git

  • Commit changed from 97e02e3cdd7c78bb28ed9060181eab7edb4ca905 to cada576b4221a3ec794b3dfdaaaa3a4684063eed

Branch pushed to git repo; I updated commit sha1. New commits:

cada576trac 21058 use sorted

comment:6 Changed 3 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:7 Changed 3 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:8 Changed 3 years ago by vbraun

  • Branch changed from public/21058 to cada576b4221a3ec794b3dfdaaaa3a4684063eed
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.