Opened 3 years ago
Closed 3 years ago
#21056 closed enhancement (fixed)
some doc correction in modular folder
Reported by:  chapoton  Owned by:  

Priority:  trivial  Milestone:  sage7.3 
Component:  documentation  Keywords:  beginner 
Cc:  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Jeroen Demeyer 
Report Upstream:  N/A  Work issues:  
Branch:  85a89c5 (Commits)  Commit:  85a89c5d8c453fc5ff36929f72571a44ad55c42c 
Dependencies:  Stopgaps: 
Description
just correct syntax for a few references.
Change History (12)
comment:1 Changed 3 years ago by
 Branch set to public/21056
 Commit set to 812767d9295df69b5701be99d8aae52feb47e8aa
 Status changed from new to needs_review
comment:2 Changed 3 years ago by
 Commit changed from 812767d9295df69b5701be99d8aae52feb47e8aa to 4672e6f879e705e2fd307c5831a67ccfca517e33
Branch pushed to git repo; I updated commit sha1. New commits:
4672e6f  INPUT formatting

comment:3 Changed 3 years ago by
If you change INPUT
blocks, could you use the standard syntax for INPUT
blocks? You are using all different kinds of formatting for the arguments.
comment:4 Changed 3 years ago by
 Commit changed from 4672e6f879e705e2fd307c5831a67ccfca517e33 to 9b7eecf90448ee8758790fa3ead9f0735300a1a2
Branch pushed to git repo; I updated commit sha1. New commits:
9b7eecf  trac 21056 more INPUT formatting as requested

comment:5 Changed 3 years ago by
I am not sure I understand what you want. This file surely needs a largescale cleanup but this is not what I want to do here and now.
comment:6 Changed 3 years ago by
 Commit changed from 9b7eecf90448ee8758790fa3ead9f0735300a1a2 to 65bdf4af16b98440e22849da76ba383d6ba0fe42
Branch pushed to git repo; I updated commit sha1. New commits:
65bdf4a  trac 21056 one more INPUT formatting

comment:7 Changed 3 years ago by
I think we have discussed something like this before.
If a file needs a largescale cleanup, then what is the point of this smallscale cleanup? You are just wasting our time with this halfway job.
comment:8 Changed 3 years ago by
To be clear: I am not asking you to do additional work. I am only asking that, if you do something, you do it right.
comment:9 Changed 3 years ago by
 Commit changed from 65bdf4af16b98440e22849da76ba383d6ba0fe42 to 85a89c5d8c453fc5ff36929f72571a44ad55c42c
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
85a89c5  trac 21056 just correct references

comment:10 Changed 3 years ago by
Here is a branch with minimal changes, only about references.
comment:11 Changed 3 years ago by
 Reviewers set to Jeroen Demeyer
 Status changed from needs_review to positive_review
comment:12 Changed 3 years ago by
 Branch changed from public/21056 to 85a89c5d8c453fc5ff36929f72571a44ad55c42c
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
a few references corrected in modular folder
one detail