Opened 13 years ago

Closed 13 years ago

#2105 closed defect (fixed)

[with patch, positive review] Constructor for ntl.GF2X polynomials does not take Polynomials over GF(2)

Reported by: malb Owned by: malb
Priority: major Milestone: sage-2.10.3
Component: basic arithmetic Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Marshall Buck on [sage-support] writes:

sage: R.<x> = GF(2)[]
sage: f = x^5+x^2+1
sage: fx = ntl.GF2X(f)

gives error:

Traceback (most recent call last):    fx
  File "ntl_GF2X.pyx", line 141, in
sage.libs.ntl.ntl_GF2X.ntl_GF2X.__init__
AttributeError: 'sage.rings.polynomial.polynomial_modn_dense_ntl.Po' object has no attribute '_Polynomial_dense_mod_n__poly'

fx = ntl.GF2X(f.list()) works, as well as fx = ntl.GF2X(f.ntl_ZZ_pX())

Attachments (1)

trac_2105.patch (1.2 KB) - added by malb 13 years ago.
fix

Download all attachments as: .zip

Change History (7)

comment:1 Changed 13 years ago by mabshoff

  • Milestone set to sage-2.10.2

comment:2 Changed 13 years ago by malb

  • Owner changed from somebody to malb
  • Status changed from new to assigned

Changed 13 years ago by malb

fix

comment:3 Changed 13 years ago by malb

  • Summary changed from Constructor for ntl.GF2X polynomials does not take Polynomials over GF(2) as advertised by docstring to [with patch, needs review] Constructor for ntl.GF2X polynomials does not take Polynomials over GF(2)

comment:4 Changed 13 years ago by mhansen

  • Summary changed from [with patch, needs review] Constructor for ntl.GF2X polynomials does not take Polynomials over GF(2) to [with patch, positive review] Constructor for ntl.GF2X polynomials does not take Polynomials over GF(2)

Looks good to me.

comment:5 Changed 13 years ago by cremona

And to me.

comment:6 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 2.10.3.rc0

Note: See TracTickets for help on using tickets.