"sage -i autotools" fails because libtool 2.4.3 requires xz

[mkoeppe]

sage -i autotools results in this error. In a parallel build, one is left with a nondeterministic collection of installed autotools versions.

export MAKE='make -j12 -j1' ; \
	export AUTOCONF_VERSION=2.62 ; \
	export AUTOMAKE_VERSION=1.11.1 ; \
	cd libtool-2.4.3 && bash bootstrap --skip-git --skip-po --gnulib-srcdir=../../src/gnulib && \
	    ./configure --prefix="/Users/mkoeppe/cvs/sage/local/libtool-2.4.3" && \
	    $MAKE && $MAKE install
bootstrap:   error: Prerequisite 'xz' not found. Please install it, or
bootstrap:          'export XZ=/path/to/xz'.
bootstrap:   error: HACKING explains how to obtain these prerequisite programs:
bootstrap:          Program    Min_version Homepage                            
bootstrap:          -----------------------------------------------------------
bootstrap:          help2man   1.29        http://www.gnu.org/s/help2man       
bootstrap:          make       3.81        http://www.gnu.org/s/make           
bootstrap:          makeinfo   4.8         http://www.gnu.org/s/texinfo        
bootstrap:          xz         4.999.8beta http://tukaani.org/xz               
bootstrap:          autoconf   2.62        http://www.gnu.org/s/autoconf       
bootstrap:          automake   1.11.1      http://www.gnu.org/s/automake       
bootstrap:          -----------------------------------------------------------
make: *** [/Users/mkoeppe/cvs/sage/local/libtool-2.4.3] Error 1

[mkoeppe]

#21063 adds the required xz package. But next it runs into a problem with the old gm4 on Mac OS X.

bootstrap: running: autoreconf --symlink --install
main::scan_file() called too early to check prototype at /Users/mkoeppe/cvs/sage/local/automake-1.11.1/bin/aclocal line 617.
m4/ltversion.m4:12: warning: ill-formed serial number `ltversion.m4', expecting a version string with only digits and dots
/Library/Developer/CommandLineTools/usr/bin/gm4: unrecognized option `--debugfile=autom4te.cache/traces.0t'
Try `/Library/Developer/CommandLineTools/usr/bin/gm4 --help' for more information.
autom4te: gm4 failed with exit status: 1

[mkoeppe]

Now it works. Needs review.

---

New commits:

​d356c75	Add xz package
​da4a28f	Use Sage m4 to build libtool
​d70e858	Add xz as dependency

[mkoeppe]

An unrelated issue with autotools that should be fixed as well. The package should actually install links "aclocal-VERSION" and "automake-VERSION" (actually am__api_version) to $SAGE_LOCAL/bin. For example, 1.14.1 and 1.14 have the same am__api_version (1.14). So we need to pick the better one I guess.

(This is so that maintainer-mode Makefile targets which call automake work. )

[jdemeyer]

What's this???

# System m4 from Mac OS X 10.11.5 is too old to bootstrap libtool 1.4.3
export M4="$SAGE_LOCAL/bin/m4"

That m4 should be the first one found in the $PATH, so I really do not see the point.

[mkoeppe]

Replying to jdemeyer:

What's this???

# System m4 from Mac OS X 10.11.5 is too old to bootstrap libtool 1.4.3
export M4="$SAGE_LOCAL/bin/m4"

That m4 should be the first one found in the $PATH, so I really do not see the point.

The configure script prefers "gm4" to "m4". That's why this is necessary.

[jdemeyer]

Replying to mkoeppe:

The configure script prefers "gm4" to "m4".

Please add this sentence to a comment in the patch and refer to this ticket.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​b2095e1	Merge tag '7.3.beta9' into t/21047/_sage__i_autotools__fails_because_libtool_2_4_3_requires_xz
​e09aaf3	Expand discussion about M4

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​ff3f2b3

Merge tag '7.3' into t/21047/_sage__i_autotools__fails_because_libtool_2_4_3_requires_xz

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​59fb410	Install symlinks bin/{aclocal,automake}-AM_API_VERSION
​72269cc	spkg-write-makefile: Remove dependency on GNU sed
​ce2b490	spkg-write-makefile: Fix wrong prereq in automake 1.10
​ba06f0e	Supply .serial file for libtool

[mkoeppe]

Replying to mkoeppe:

An unrelated issue with autotools that should be fixed as well. The package should actually install links "aclocal-VERSION" and "automake-VERSION" (actually am__api_version) to $SAGE_LOCAL/bin. For example, 1.14.1 and 1.14 have the same am__api_version (1.14). So we need to pick the better one I guess.

(This is so that maintainer-mode Makefile targets which call automake work. )

This is done now.

[mkoeppe]

I have also fixed the installation of libtool's ltversion.m4, which was missing the serial number (.serial), causing the following warning.

m4/ltversion.m4:12: warning: ill-formed serial number 'ltversion.m4', expecting a version string with only digits and dots

[mkoeppe]

It now works fine for me. Needs review.

Follow-up ticket: #21196 - Upgrade autotools

[jdemeyer]

Style question: why did you change this part?

sed 's/^/\t/;' <<EOF
cd $p-$v && ${bootstrap}\\
    ./configure --prefix="\$(SAGE_LOCAL)/$p-$v" && \\
    \$\$MAKE && \$\$MAKE install
# Remove all files except for the .* files
[ "\$\$SAGE_KEEP_BUILT_SPKGS" = yes ] || rm -rf $p-$v/*
EOF

I thought it was a very nice way to not have to write too many backslashes....

I think that spkg-write-makefile needs more documentation. All the changes that you did are non-trivial and should be documented better. What does # Fix up for wrong prereq. mean for example?

[mkoeppe]

Replying to jdemeyer:

Style question: why did you change this part?

sed 's/^/\t/;' <<EOF
cd $p-$v && ${bootstrap}\\
    ./configure --prefix="\$(SAGE_LOCAL)/$p-$v" && \\
    \$\$MAKE && \$\$MAKE install
# Remove all files except for the .* files
[ "\$\$SAGE_KEEP_BUILT_SPKGS" = yes ] || rm -rf $p-$v/*
EOF

I thought it was a very nice way to not have to write too many backslashes....

Unfortunately using '\t' only works with GNU sed, not with the traditional sed that is available on Mac OS X. (See commit message).

I think that spkg-write-makefile needs more documentation. All the changes that you did are non-trivial and should be documented better.

OK, I'll add some.

What does # Fix up for wrong prereq. mean for example?

It's a fix for an automake version that has a too low autoconf requirement listed in its source. I believe in the current spkg, someone must have fixed this by hand-editing the Makefile.build.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​afe7062

add more comments

[jdemeyer]

Also: please remove this:

+	    # Could instead compute the .serial at "make" time:
+	    #echo -e "\tif test ! -f \"$p-$v/.serial\"; then ( cd \$(SRC)/$p && git log --pretty=oneline $tag ) |wc -l | sed 's|[\t ]||g ' > $p-$v/.serial ; fi"

It's only confusing...

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​c60f495

remove commented out code

[jdemeyer]

Have you tested this version on OS X? I can test Linux but not OS X.

[jdemeyer]

Why do you need the .serial files?

[mkoeppe]

Replying to jdemeyer:

Why do you need the .serial files?

See comment 14 - it's also explained in the comment that I added to spkg-write-makefile

[mkoeppe]

Replying to jdemeyer:

Have you tested this version on OS X?

Yes

[jdemeyer]

Replying to mkoeppe:

it's also explained in the comment that I added to spkg-write-makefile

Well, that comment only explains why that file is missing. Not why it is needed.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​7894375

Add more documentation

[mkoeppe]

enough documentation?

[mkoeppe]

ping?