Opened 6 years ago
Closed 22 months ago
#21031 closed defect (wontfix)
"sage package update" nukes checksums.ini on error
Reported by:  Matthias Köppe  Owned by:  

Priority:  major  Milestone:  sageduplicate/invalid/wontfix 
Component:  build  Keywords:  sd111 
Cc:  Volker Braun, Jeroen Demeyer  Merged in:  
Authors:  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  Commit:  
Dependencies:  Stopgaps: 
Description (last modified by )
When something goes wrong during sage package update
because of a typo, the checksums.ini
file is left empty.
Example:
./sage package update normaliz 3.1.1000
Change History (9)
comment:1 Changed 6 years ago by
Description:  modified (diff) 

Milestone:  sage7.3 → sage7.6 
comment:2 Changed 5 years ago by
Milestone:  sage7.6 → sage8.1 

comment:3 Changed 22 months ago by
Keywords:  sd111 added 

comment:4 Changed 22 months ago by
I can't reproduce this. However, build/pkgs/normaliz/packageversion.txt
is changed regardless, which isn't optimal.
comment:5 Changed 22 months ago by
Authors:  → Jonathan Kliem 

Branch:  → public/21031 
Commit:  → 25c52fd778f1d15f4ed89844d5fa67f9e5c4f09d 
Status:  new → needs_review 
New commits:
25c52fd  restore version number on failure

comment:6 Changed 22 months ago by
This at least restores the previous version number (or tries to).
I don't know, if it is worth it.
comment:8 Changed 22 months ago by
Authors:  Jonathan Kliem 

Branch:  public/21031 
Commit:  25c52fd778f1d15f4ed89844d5fa67f9e5c4f09d 
Milestone:  sage8.1 → sageduplicate/invalid/wontfix 
Okay. The only use case would be a person having the sources but not in a git repository and trying to update. If this is the case, the person would have to fix the version number itself. I think this is ok.
comment:9 Changed 22 months ago by
Resolution:  → wontfix 

Status:  needs_review → closed 
Note: See
TracTickets for help on using
tickets.
Hoping we can make progress on this ticket this week  https://wiki.sagemath.org/days111