Opened 6 years ago

Closed 6 years ago

#21023 closed enhancement (fixed)

remove traces of mercurial in sage/misc/banner.py

Reported by: schilly Owned by:
Priority: trivial Milestone: sage-7.3
Component: misc Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: da47af1 (Commits, GitHub, GitLab) Commit: da47af133c0e897846938491a73a9a8a0a349d6d
Dependencies: Stopgaps:

Status badges

Description

In sage/misc/banner.py the function version(clone = False) does read the filesystem for a mercurial branch info every time. Remove this os.popen(...) and get rid of clone. Maybe there are similar traces in such files, too ...

Change History (11)

comment:1 Changed 6 years ago by chapoton

  • Authors set to Frédéric Chapoton
  • Branch set to public/21023
  • Commit set to 9474725429dfdd084e86ad93fcd3648240683c0b
  • Status changed from new to needs_review

New commits:

9474725remove clone option of version in banner.py

comment:2 Changed 6 years ago by jmantysalo

Just

fgrep -R -i -l mercurial src/sage

found seven files referring to Mercurial. Do you want this ticket to be reviewed, or to check those first?

comment:3 follow-up: Changed 6 years ago by chapoton

Indeed. See also git grep -P "ercurial"

Do we still ship the package hg ?

comment:4 in reply to: ↑ 3 Changed 6 years ago by jmantysalo

Replying to chapoton:

Do we still ship the package hg ?

No idea. I don't really know Sage to be able to answer questions like this.

comment:5 follow-up: Changed 6 years ago by chapoton

So let us please just use this ticket for its current minimal changes.

comment:6 in reply to: ↑ 5 Changed 6 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo
  • Status changed from needs_review to positive_review

Replying to chapoton:

So let us please just use this ticket for its current minimal changes.

OK.

comment:7 Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_work
sage -t --long src/sage/misc/abstract_method.py  # 1 doctest failed
sage -t --long src/sage/misc/lazy_attribute.pyx  # 1 doctest failed

comment:8 Changed 6 years ago by git

  • Commit changed from 9474725429dfdd084e86ad93fcd3648240683c0b to da47af133c0e897846938491a73a9a8a0a349d6d

Branch pushed to git repo; I updated commit sha1. New commits:

da47af1trac 21023 correct doctests

comment:9 Changed 6 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:10 Changed 6 years ago by jmantysalo

  • Status changed from needs_review to positive_review

Works now.

comment:11 Changed 6 years ago by vbraun

  • Branch changed from public/21023 to da47af133c0e897846938491a73a9a8a0a349d6d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.