Opened 5 years ago

Closed 5 years ago

#20967 closed defect (fixed)

Make behavior of charpoly in Rational consistent with other instances of charpoly

Reported by: klui Owned by:
Priority: trivial Milestone: sage-7.3
Component: algebra Keywords: rational, charpoly
Cc: Merged in:
Authors: Kevin Lui Reviewers: William Stein
Report Upstream: N/A Work issues:
Branch: a4426f6 (Commits, GitHub, GitLab) Commit: a4426f6c80fbe71aad8c9ba447c60fae4d974d71
Dependencies: Stopgaps:

Status badges

Description

Currently, charpoly in Rational does not have a default var.

sage: a = QQ(2); a.charpoly()
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-1-b2bd5f519d4e> in <module>()
----> 1 a = QQ(Integer(2)); a.charpoly()

TypeError: charpoly() takes exactly one argument (0 given)

Over other rings, it does have a default var.

sage: K.<a> = NumberField(x^2-2); a.charpoly()
x^2 - 2

Change History (7)

comment:1 Changed 5 years ago by klui

  • Branch set to u/klui/make_behavior_of_charpoly_in_rational_consistent_with_other_instances_of_charpoly

comment:2 Changed 5 years ago by klui

  • Commit set to a4426f6c80fbe71aad8c9ba447c60fae4d974d71
  • Status changed from new to needs_review

New commits:

a4426f6added var='x' to charpoly() in rational.pyx

comment:3 Changed 5 years ago by was

This looks good (and safe) to me.

comment:4 Changed 5 years ago by was

  • Status changed from needs_review to positive_review

comment:5 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name is missig

comment:6 Changed 5 years ago by was

  • Reviewers set to William Stein
  • Status changed from needs_work to positive_review

<rant>It is so pointless that this is done manually.</rant>

comment:7 Changed 5 years ago by vbraun

  • Branch changed from u/klui/make_behavior_of_charpoly_in_rational_consistent_with_other_instances_of_charpoly to a4426f6c80fbe71aad8c9ba447c60fae4d974d71
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.