Opened 5 years ago

Closed 5 years ago

#20962 closed enhancement (fixed)

py3 handling some removed members of types module

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: fcea6e8 (Commits, GitHub, GitLab) Commit: fcea6e82c0b4c68e441062de9722b02c47015e12
Dependencies: Stopgaps:

Status badges

Description

split from #15994 as the more easy part

Change History (9)

comment:1 Changed 5 years ago by chapoton

  • Branch set to public/20962
  • Commit set to d091c43670edab22dba314c779511abc63f6b304
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit changed from d091c43670edab22dba314c779511abc63f6b304 to a59ee0007fe8e0b93a5db8ae1a7efab155113dd6

Branch pushed to git repo; I updated commit sha1. New commits:

a59ee00trac 20962 some types change in py3

comment:3 Changed 5 years ago by vdelecroix

Authors?

comment:4 Changed 5 years ago by chapoton

  • Authors set to Frédéric Chapoton

me (starting to get tired..)

comment:5 Changed 5 years ago by jmantysalo

  • Status changed from needs_review to needs_work

I dont know enought to review this, but at least src/sage/combinat/finite_state_machine.py fails just like a patchbot says.

comment:6 Changed 5 years ago by git

  • Commit changed from a59ee0007fe8e0b93a5db8ae1a7efab155113dd6 to fcea6e82c0b4c68e441062de9722b02c47015e12

Branch pushed to git repo; I updated commit sha1. New commits:

fcea6e8trac 20962 one detail

comment:7 Changed 5 years ago by chapoton

  • Status changed from needs_work to needs_review

doctest corrected.

comment:8 Changed 5 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:9 Changed 5 years ago by vbraun

  • Branch changed from public/20962 to fcea6e82c0b4c68e441062de9722b02c47015e12
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.