Opened 5 years ago

Closed 5 years ago

#20953 closed enhancement (fixed)

Improve minimum_distance for linear codes

Reported by: dlucas Owned by:
Priority: major Milestone: sage-7.6
Component: coding theory Keywords: rd3
Cc: Merged in:
Authors: David Lucas Reviewers: Julien Lavauzelle
Report Upstream: N/A Work issues:
Branch: 804d2f2 (Commits, GitHub, GitLab) Commit: 804d2f2c9d6c9a050502c31220d2a295b9ff1a27
Dependencies: Stopgaps:

Status badges

Description

The method minimum_distance (and related method min_wt_vec_gap) can be improved in several ways, by:

  • rewriting its documentation
  • changing some names
  • adding explicit error messages when the user uses the Guava option without

Guava installed on his system.

This ticket takes care of the above improvements.

Change History (6)

comment:1 Changed 5 years ago by dlucas

  • Branch set to u/dlucas/clean_minimum_distance

comment:2 Changed 5 years ago by dlucas

  • Authors set to David Lucas
  • Commit set to f0e15e476cb6c20afc843fe2e0664103220470d1
  • Status changed from new to needs_review

I pushed the branch, which contains the following changes:

  • renamed min_wt_vec_gap as _minimum_weight_codeword, moved it inside AbstractLinearCode (was a global method) and made it a private method.
  • Rewrote documentation of _minimum_weight_codeword and minimum_distance, removed useless doctests.
  • Removed a useless variable, factored some code.
  • Added a proper check when the user calls algorithm="guava". If the user does not have Guava installed, it will fail with a proper error message instead of some random GAP error.

This is open for review.

Best,

David


New commits:

b467744Improved min_wt_vec_gap
a052919Reworked minimum_distance
f0e15e4Minor changes to the code

comment:3 Changed 5 years ago by ylchapuy

  • Milestone sage-7.3 deleted
  • Status changed from needs_review to needs_work

merge conflict

comment:4 Changed 5 years ago by jlavauzelle

  • Branch changed from u/dlucas/clean_minimum_distance to u/jlavauzelle/clean_minimum_distance

comment:5 Changed 5 years ago by jlavauzelle

  • Commit changed from f0e15e476cb6c20afc843fe2e0664103220470d1 to 804d2f2c9d6c9a050502c31220d2a295b9ff1a27
  • Keywords rd3 added
  • Milestone set to sage-7.6
  • Reviewers set to Julien Lavauzelle
  • Status changed from needs_work to positive_review

Hi David,

I merged what you've done previously and I checked that doctests pass. Everything seems ok to me. I give a positive review.

Julien


New commits:

da01272Fixed merge conflict. Doctests pass.
804d2f2Removed deprecation alias for min_wt_vec_gap

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/jlavauzelle/clean_minimum_distance to 804d2f2c9d6c9a050502c31220d2a295b9ff1a27
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.