Opened 5 years ago

Closed 5 years ago

#20952 closed defect (fixed)

fixing two optional guava doctests

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: coding theory Keywords:
Cc: dlucas, wdj Merged in:
Authors: Frédéric Chapoton Reviewers: David Lucas
Report Upstream: N/A Work issues:
Branch: 7033f3b (Commits, GitHub, GitLab) Commit: 7033f3bec91623ddb8734eb7e5e3bebe1a6f63ec
Dependencies: Stopgaps:

Status badges

Description

that are currently breaking all reports of a patchbot

Change History (9)

comment:1 Changed 5 years ago by chapoton

  • Branch set to public/20952
  • Cc dlucas wdj added
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by chapoton

  • Commit set to aaa9f7ca5ccbad8057107ad10b6ef2bc307a2d9a

@dlucas, could you please have a quick look at this ticket ?


New commits:

aaa9f7cfixing 2 optional guava doctests

comment:3 Changed 5 years ago by dlucas

Hello,

I have a question: I noticed BinaryReedMullerCode in guava.py is basically dead code. We reimplemented it as a proper class in #20705 and it's no longer imported. If it's fine with you, can you delete it in this ticket? I don't think it's necessary to open another ticket to remove this method.

David

comment:4 Changed 5 years ago by git

  • Commit changed from aaa9f7ca5ccbad8057107ad10b6ef2bc307a2d9a to 0b6ff31166fd88eba63ca59ab4aab0c610aeed37

Branch pushed to git repo; I updated commit sha1. New commits:

0b6ff31trac 20952 removing guava Binary Reed-Muller Code

comment:5 Changed 5 years ago by git

  • Commit changed from 0b6ff31166fd88eba63ca59ab4aab0c610aeed37 to 7033f3bec91623ddb8734eb7e5e3bebe1a6f63ec

Branch pushed to git repo; I updated commit sha1. New commits:

7033f3busing relative import

comment:6 Changed 5 years ago by dlucas

  • Status changed from needs_review to positive_review

Ok, tests pass, I set this to positive_review.

David

comment:7 Changed 5 years ago by jmantysalo

  • Status changed from positive_review to needs_work

Needs a reviewer name.

(And trac needs a plugin to automatically force it!)

comment:8 Changed 5 years ago by dlucas

  • Reviewers set to David Lucas
  • Status changed from needs_work to positive_review

Oops, sorry.

Done now!

comment:9 Changed 5 years ago by vbraun

  • Branch changed from public/20952 to 7033f3bec91623ddb8734eb7e5e3bebe1a6f63ec
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.