Opened 6 years ago
Last modified 5 years ago
#20946 closed enhancement
update giac spkg — at Version 9
Reported by:  frederichan  Owned by:  

Priority:  major  Milestone:  sage7.5 
Component:  packages: optional  Keywords:  giac 
Cc:  Merged in:  
Authors:  Han Frederic  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  public/giacupdate (Commits, GitHub, GitLab)  Commit:  eb2591b22c809a5aea4fbed08aadfb110ca31e11 
Dependencies:  Stopgaps: 
Description (last modified by )
Update the spkg to upstream 1.2.269
The giac tarball built from spkgsrc to put in upstream/ is there:
http://webusers.imjprg.fr/~frederic.han/xcas/sage/giac1.2.2.69.tar.bz2
Switch to .bz2 as wished in #18826
add disableao in spkginstall to avoid libao dependency. remove the disablegmpxx in spkginstall. The built seems not broken anymore.
updtate giacpy to 0.6 doctest fix + change of name to giacpy_sage. The tarball to put in upstream is: http://webusers.imjprg.fr/~frederic.han/xcas/giacpy/sage/giacpy0.6.tar.gz
The modifications about giacpy are there: https://gitlab.math.univparisdiderot.fr/han/giacpysage
Change History (9)
comment:1 followup: ↓ 2 Changed 6 years ago by
 Status changed from new to needs_review
comment:2 in reply to: ↑ 1 Changed 6 years ago by
Replying to leif:
You're not (yet?) listed here, so hopefully I've not misspelled your name.
its done.
I need to test more. Ex:
Failed example: [giacpy0.5.6] f=1/(5+cos(4*x));f.int(x) [giacpy0.5.6] Expected: [giacpy0.5.6] 1/2/(2*sqrt(6))*(atan(2*tan(4*x/2)/sqrt(6))+pi*floor(4*x/2/pi+1/2)) [giacpy0.5.6] Got: [giacpy0.5.6] 1/2/(2*sqrt(6))*(atan((sqrt(6)*sin(4*x)+2*sin(4*x))/(sqrt(6)*cos(4*x)+sqrt(6)2*cos(4*x)+2))+4*x/2)
comment:3 Changed 6 years ago by
 Status changed from needs_review to needs_work
comment:4 Changed 6 years ago by
 Commit set to 88c2d0a0227bb9d58e079d67810cae3b659938de
comment:5 Changed 6 years ago by
 Description modified (diff)
comment:6 Changed 6 years ago by
 Commit changed from 88c2d0a0227bb9d58e079d67810cae3b659938de to c660391efb842671620f062bc6acae741dab1db3
Branch pushed to git repo; I updated commit sha1. New commits:
c660391  change the name of the spkg giacpy to giacpy_sage

comment:7 Changed 6 years ago by
Comment 2 is not a problem. This change was done on purpose in giac, both answer are correct. giacpy0.6 doctests can deal with both answers.
I am waiting a bit more because I have found a bug in 1.2.2.67 http://xcas.e.ujfgrenoble.fr/XCAS/viewtopic.php?f=3&t=1731
comment:8 Changed 6 years ago by
 Commit changed from c660391efb842671620f062bc6acae741dab1db3 to eb2591b22c809a5aea4fbed08aadfb110ca31e11
Branch pushed to git repo; I updated commit sha1. New commits:
eb2591b  update to giac1.2.269

comment:9 Changed 6 years ago by
 Description modified (diff)
You're not (yet?) listed here, so hopefully I've not misspelled your name.