Opened 6 years ago

Last modified 5 years ago

#20946 closed enhancement

update giac spkg — at Version 5

Reported by: frederichan Owned by:
Priority: major Milestone: sage-7.5
Component: packages: optional Keywords: giac
Cc: Merged in:
Authors: Han Frederic Reviewers:
Report Upstream: N/A Work issues:
Branch: public/giacupdate (Commits, GitHub, GitLab) Commit: 88c2d0a0227bb9d58e079d67810cae3b659938de
Dependencies: Stopgaps:

Status badges

Description (last modified by frederichan)

Update the spkg to upstream 1.2.2-67

The giac tarball built from spkg-src to put in upstream/ is there:

http://webusers.imj-prg.fr/~frederic.han/xcas/sage/giac-1.2.2.67.tar.bz2

Switch to .bz2 as wished in #18826

add --disable-ao in spkg-install to avoid libao dependency. remove the --disable-gmpxx in spkg-install. The built seems not broken anymore.

updtate giacpy to 0.6 doctest fix + change of name to giacpy_sage. The tarball to put in upstream is: http://webusers.imj-prg.fr/~frederic.han/xcas/giacpy/sage/giacpy-0.6.tar.gz

The modifications about giacpy are there: https://gitlab.math.univ-paris-diderot.fr/han/giacpy-sage

Change History (5)

comment:1 follow-up: Changed 6 years ago by leif

  • Authors set to Han Frederic
  • Status changed from new to needs_review

You're not (yet?) listed here, so hopefully I've not misspelled your name.

comment:2 in reply to: ↑ 1 Changed 6 years ago by frederichan

Replying to leif:

You're not (yet?) listed here, so hopefully I've not misspelled your name.

its done.

I need to test more. Ex:

Failed example:
[giacpy-0.5.6]     f=1/(5+cos(4*x));f.int(x)
[giacpy-0.5.6] Expected:
[giacpy-0.5.6]     1/2/(2*sqrt(6))*(atan(2*tan(4*x/2)/sqrt(6))+pi*floor(4*x/2/pi+1/2))
[giacpy-0.5.6] Got:
[giacpy-0.5.6]     1/2/(2*sqrt(6))*(atan((-sqrt(6)*sin(4*x)+2*sin(4*x))/(sqrt(6)*cos(4*x)+sqrt(6)-2*cos(4*x)+2))+4*x/2)

comment:3 Changed 6 years ago by frederichan

  • Status changed from needs_review to needs_work

comment:4 Changed 6 years ago by git

  • Commit set to 88c2d0a0227bb9d58e079d67810cae3b659938de

Branch pushed to git repo; I updated commit sha1. New commits:

600e7a6update to giacpy 0.6. start to change the name from giacpy to giacpy_sage
adae5f7fixes changes of name for giacpy in src/sage/libs/giac.py
88c2d0aupdate SPKG.txt

comment:5 Changed 6 years ago by frederichan

  • Description modified (diff)
Note: See TracTickets for help on using tickets.