Opened 7 years ago
Closed 6 years ago
#20946 closed enhancement (fixed)
update giac spkg
Reported by:  frederichan  Owned by:  

Priority:  major  Milestone:  sage7.5 
Component:  packages: optional  Keywords:  giac 
Cc:  Merged in:  
Authors:  Frederic Han  Reviewers:  Ralf Stephan 
Report Upstream:  N/A  Work issues:  
Branch:  c709c1e (Commits, GitHub, GitLab)  Commit:  c709c1ee6a931eb906284a038e52acd4b200fcc4 
Dependencies:  Stopgaps: 
Description (last modified by )
Update the spkg to upstream 1.2.295
The giac tarball built from spkgsrc to put in upstream/ is there:
http://webusers.imjprg.fr/~frederic.han/xcas/sage/giac1.2.2.95.tar.bz2
Switch to .bz2 as wished in #18826
add disableao in spkginstall to avoid libao dependency. remove the disablegmpxx in spkginstall. The built seems not broken anymore.
updtate giacpy to 0.6 doctest fix + change of name to giacpy_sage. The tarball to put in upstream is: http://webusers.imjprg.fr/~frederic.han/xcas/giacpy/sage/giacpy_sage0.6.tar.gz
The modifications about giacpy are there: https://gitlab.math.univparisdiderot.fr/han/giacpysage
The 1.2.2.85 version of giac should fix a race condition in icas that could appear during the test suite.
Change History (35)
comment:1 followup: 2 Changed 7 years ago by
Authors:  → Han Frederic 

Status:  new → needs_review 
comment:2 Changed 7 years ago by
Replying to leif:
You're not (yet?) listed here, so hopefully I've not misspelled your name.
its done.
I need to test more. Ex:
Failed example: [giacpy0.5.6] f=1/(5+cos(4*x));f.int(x) [giacpy0.5.6] Expected: [giacpy0.5.6] 1/2/(2*sqrt(6))*(atan(2*tan(4*x/2)/sqrt(6))+pi*floor(4*x/2/pi+1/2)) [giacpy0.5.6] Got: [giacpy0.5.6] 1/2/(2*sqrt(6))*(atan((sqrt(6)*sin(4*x)+2*sin(4*x))/(sqrt(6)*cos(4*x)+sqrt(6)2*cos(4*x)+2))+4*x/2)
comment:3 Changed 7 years ago by
Status:  needs_review → needs_work 

comment:4 Changed 7 years ago by
Commit:  → 88c2d0a0227bb9d58e079d67810cae3b659938de 

comment:5 Changed 7 years ago by
Description:  modified (diff) 

comment:6 Changed 7 years ago by
Commit:  88c2d0a0227bb9d58e079d67810cae3b659938de → c660391efb842671620f062bc6acae741dab1db3 

Branch pushed to git repo; I updated commit sha1. New commits:
c660391  change the name of the spkg giacpy to giacpy_sage

comment:7 Changed 7 years ago by
Comment 2 is not a problem. This change was done on purpose in giac, both answer are correct. giacpy0.6 doctests can deal with both answers.
I am waiting a bit more because I have found a bug in 1.2.2.67 http://xcas.e.ujfgrenoble.fr/XCAS/viewtopic.php?f=3&t=1731
comment:8 Changed 7 years ago by
Commit:  c660391efb842671620f062bc6acae741dab1db3 → eb2591b22c809a5aea4fbed08aadfb110ca31e11 

Branch pushed to git repo; I updated commit sha1. New commits:
eb2591b  update to giac1.2.269

comment:9 Changed 7 years ago by
Description:  modified (diff) 

comment:10 Changed 7 years ago by
Status:  needs_work → needs_review 

comment:11 followup: 14 Changed 7 years ago by
Darn, I have to update my ebuild for Gentoo. Since we have a spkgsrc
already should i fix it to get lapack
in sage like I did in sageongentoo or should we wait a bit?
I would also prefer if the tarball and the folder in which giacpy_sage unfold were matching the new package name.
comment:12 Changed 7 years ago by
Description:  modified (diff) 

comment:13 Changed 7 years ago by
Commit:  eb2591b22c809a5aea4fbed08aadfb110ca31e11 → ddfde459fae8fdce2bfaca37c269edb0f480e5f7 

Branch pushed to git repo; I updated commit sha1. New commits:
ddfde45  change the tarball name of giacpy to giacpy_sage

comment:14 followup: 15 Changed 7 years ago by
Replying to fbissey:
Darn, I have to update my ebuild for Gentoo. Since we have a
spkgsrc
already should i fix it to getlapack
in sage like I did in sageongentoo or should we wait a bit?
Feel free to modify as you want, I have put it on a public branch for this. I have no news from parisse about a lapack change except the discussion on sagedevel.
I would also prefer if the tarball and the folder in which giacpy_sage unfold were matching the new package name.
should be done now
comment:15 Changed 7 years ago by
Replying to frederichan:
Replying to fbissey:
Darn, I have to update my ebuild for Gentoo. Since we have a
spkgsrc
already should i fix it to getlapack
in sage like I did in sageongentoo or should we wait a bit?Feel free to modify as you want, I have put it on a public branch for this. I have no news from parisse about a lapack change except the discussion on sagedevel.
Yes I can do a simple thing that will work in sage as it works on gentoo since we have .pc files for blas/lapack. Probably won't work for parisse.
I would also prefer if the tarball and the folder in which giacpy_sage unfold were matching the new package name.
should be done now
Thank you.
comment:16 followup: 17 Changed 7 years ago by
Hum I am unwilling to touch the spkgsrc
while I don't completely understand it. I would regenerate Makefile.in
and co and probably wreak havoc in the current setup. Better ship it as it is now. If we really want lapack support we'll work it out later.
Actually the current configuration will work on OS X I think and it is ok not to disable it as the runtime involved comes with the OS.
What is the last bit of spkginst
supposed to do?
# create the script_subdirectory for the pexpect giac interface by running a trivial instruction sage c "giac(1)" if [ $? ne 0 ]; then echo >&2 "Error running the pexpect interface of giac" exit 1 fi
Where is the directory supposed to be created? I cannot see anything new when I run ./sage p giac
with this branch. I was, possibly, expecting something in local/share/sage/ext
but found nothing there.
Running ./sage c "giac(1)"
manually afterwards didn't have an impact either.
comment:17 Changed 7 years ago by
Replying to fbissey:
Hum I am unwilling to touch the
spkgsrc
while I don't completely understand it. I would regenerateMakefile.in
and co and probably wreak havoc in the current setup. Better ship it as it is now. If we really want lapack support we'll work it out later.Actually the current configuration will work on OS X I think and it is ok not to disable it as the runtime involved comes with the OS.
What is the last bit of
spkginst
supposed to do?# create the script_subdirectory for the pexpect giac interface by running a trivial instruction sage c "giac(1)" if [ $? ne 0 ]; then echo >&2 "Error running the pexpect interface of giac" exit 1 fiWhere is the directory supposed to be created? I cannot see anything new when I run
./sage p giac
with this branch. I was, possibly, expecting something inlocal/share/sage/ext
but found nothing there. Running./sage c "giac(1)"
manually afterwards didn't have an impact either.
Indeed It looks obsolete. may by since #17044. Moreover I think that it is the only dependency of SAGE_RUNTIMES cf #19672 comment 6 and jeroen answer. I am trying to remove both.
comment:18 Changed 7 years ago by
Commit:  ddfde459fae8fdce2bfaca37c269edb0f480e5f7 → 95c7d7cb1453cea41216cafccf62885e476399ab 

Branch pushed to git repo; I updated commit sha1. New commits:
912a9ce  Merge branch 'develop' of git://trac.sagemath.org/sage into giacupdate

82bbbb4  Remove built of script_subdirectory for the pexpect interface. (Obsolete since #17044)

95c7d7c  remove SAGE_RUNTIME dependencies because only sage c "giac(1)" in spkg_install needed it. (Cf #19672)

comment:19 Changed 7 years ago by
Commit:  95c7d7cb1453cea41216cafccf62885e476399ab → 7a407a526acbe448c4fd62f1e1931775b939d478 

Branch pushed to git repo; I updated commit sha1. New commits:
7a407a5  add SAGERUNTIME in giacpy_sage dependencies

comment:20 Changed 7 years ago by
Authors:  Han Frederic → Frederic Han 

comment:22 Changed 6 years ago by
Commit:  7a407a526acbe448c4fd62f1e1931775b939d478 → d2ae1dd1b095cdb20db5c35708190431537c92c1 

comment:23 Changed 6 years ago by
Description:  modified (diff) 

comment:24 Changed 6 years ago by
Commit:  d2ae1dd1b095cdb20db5c35708190431537c92c1 → baa4eeb49aa7afb3a8bda950dd85108e2d963554 

Branch pushed to git repo; I updated commit sha1. New commits:
baa4eeb  update to giac1.2.2.85. This version fix a race condition with icas and jordan that could appear with the test suite

comment:25 Changed 6 years ago by
Description:  modified (diff) 

comment:26 Changed 6 years ago by
Status:  needs_work → needs_review 

comment:27 Changed 6 years ago by
Reviewers:  → Ralf Stephan 

Status:  needs_review → positive_review 
Passes make ptestlong
with optional=atlas,ccache,giac,git_trac,mpir,python2,sage
on a system where the old version was installed. I don't think there is something amiss in the package updates. Anyway it's an optional package and an improvement so I'll set positive.
comment:28 Changed 6 years ago by
Status:  positive_review → needs_work 

This conflicts with blocker ticket #21441, please rebase on top of that.
comment:29 Changed 6 years ago by
Dependencies:  → #21441 

comment:30 Changed 6 years ago by
Commit:  baa4eeb49aa7afb3a8bda950dd85108e2d963554 → a12a3ac420483b0a1d607e76985f743ed94a5bd0 

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
bb613fd  update SPKG.txt

0bf00dc  change the name of the spkg giacpy to giacpy_sage

a6418e4  update to giac1.2.269

d601e2b  change the tarball name of giacpy to giacpy_sage

6dcce70  Remove built of script_subdirectory for the pexpect interface. (Obsolete since #17044)

f081cec  remove SAGE_RUNTIME dependencies because only sage c "giac(1)" in spkg_install needed it. (Cf #19672)

eb18297  add SAGERUNTIME in giacpy_sage dependencies

1c01bc7  update giac to 1.2.2.81. adapt the cSolve patch

d80f7a8  update to giac1.2.2.85. This version fix a race condition with icas and jordan that could appear with the test suite

a12a3ac  Merge branch 'public/giacupdate' of git://trac.sagemath.org/sage into giacupdate

comment:31 Changed 6 years ago by
Status:  needs_work → needs_review 

So I have rebased on u/jdemeyer/sagepipinstall
comment:32 Changed 6 years ago by
Commit:  a12a3ac420483b0a1d607e76985f743ed94a5bd0 → c709c1ee6a931eb906284a038e52acd4b200fcc4 

comment:33 Changed 6 years ago by
Description:  modified (diff) 

comment:34 Changed 6 years ago by
Dependencies:  #21441 

Milestone:  sage7.3 → sage7.5 
Status:  needs_review → positive_review 
I am not sure why this is not back to positive review. Let's try again.
comment:35 Changed 6 years ago by
Branch:  public/giacupdate → c709c1ee6a931eb906284a038e52acd4b200fcc4 

Resolution:  → fixed 
Status:  positive_review → closed 
You're not (yet?) listed here, so hopefully I've not misspelled your name.