Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#20913 closed defect (fixed)

Patch pip to work without SSL support

Reported by: embray Owned by:
Priority: major Milestone: sage-7.3
Component: packages: standard Keywords: pip
Cc: Merged in:
Authors: Erik Bray Reviewers: Jeroen Demeyer
Report Upstream: Reported upstream. Developers acknowledge bug. Work issues:
Branch: b18d84d (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by embray)

This fixes a long-standing issue where if Sage is built on a system without OpenSSL support, doing anything with pip will result in it crashing.

This allows pip to work without SSL support. Its functionality is limited--i.e. it can't download anything from PyPI without SSL. But it does have appropriate error-handling in this case, an can still be used to install local packages fine.

This was originally part of #20218 but I am breaking it out to a separate ticket as requested.

The relevant upstream issue is here: https://github.com/pypa/pip/issues/1165

Change History (8)

comment:1 Changed 4 years ago by embray

  • Status changed from new to needs_review

comment:2 Changed 4 years ago by git

  • Commit changed from 71af67041bed29a39922772386875492951331f9 to b18d84d2044a56b7f59b02ba4a0cfa50e6140a1d

Branch pushed to git repo; I updated commit sha1. New commits:

b18d84dBump pip package patch level

comment:3 follow-up: Changed 4 years ago by jdemeyer

Do you happen to know how this should be tested, i.e. can I "fake" that I don't have SSL?

comment:4 in reply to: ↑ 3 Changed 4 years ago by embray

Replying to jdemeyer:

Do you happen to know how this should be tested, i.e. can I "fake" that I don't have SSL?

Sure. For example put a module called ssl.py that does nothing but raise an ImportError somewhere early on your PYTHONPATH. That's how I tested this.

Welcome back, also!

Last edited 4 years ago by embray (previous) (diff)

comment:5 Changed 4 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to needs_info

Can you add links in the ticket description to the upstream issue?

comment:6 Changed 4 years ago by jdemeyer

  • Status changed from needs_info to positive_review

Works fine.

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/embray/pip-ssl-patch to b18d84d2044a56b7f59b02ba4a0cfa50e6140a1d
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 4 years ago by embray

  • Commit b18d84d2044a56b7f59b02ba4a0cfa50e6140a1d deleted
  • Description modified (diff)
Note: See TracTickets for help on using tickets.