Opened 5 years ago

Closed 5 years ago

#20910 closed enhancement (fixed)

python3 urlopen in one script

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: python3 Keywords:
Cc: embray, vbraun, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: b4d89be (Commits, GitHub, GitLab) Commit: b4d89be8df408ccfbfb1e3bc3751254e60390c3c
Dependencies: Stopgaps:

Status badges

Description

in trying to move towards python3, a small step:

having the import of urlopen in the script sage-list-packages correct

Change History (7)

comment:1 Changed 5 years ago by chapoton

  • Branch set to public/20910
  • Cc embray vbraun jdemeyer added
  • Commit set to b4d89be8df408ccfbfb1e3bc3751254e60390c3c
  • Status changed from new to needs_review

New commits:

b4d89bepython3-compatible import of urlopen in sage-list-packages

comment:2 Changed 5 years ago by git

  • Commit changed from b4d89be8df408ccfbfb1e3bc3751254e60390c3c to ca314c3004028cd86c8f39ed39dfd7f589d6fa3a

Branch pushed to git repo; I updated commit sha1. New commits:

3c63c68Merge branch 'public/20910' into 7.3.b6
ca314c3using six for the import of urlopen

comment:3 Changed 5 years ago by embray

This assumes that six should be installed in the system Python. I don't think we can necessarily rely on that, though we could just document it as a build dependency (I certainly wouldn't mind; I don't know if others care though).

comment:4 Changed 5 years ago by git

  • Commit changed from ca314c3004028cd86c8f39ed39dfd7f589d6fa3a to b4d89be8df408ccfbfb1e3bc3751254e60390c3c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

comment:5 Changed 5 years ago by chapoton

ping ?

comment:6 Changed 5 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:7 Changed 5 years ago by vbraun

  • Branch changed from public/20910 to b4d89be8df408ccfbfb1e3bc3751254e60390c3c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.