Opened 5 years ago

Closed 5 years ago

#20909 closed defect (fixed)

not using string.join any longer

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: python3 Keywords:
Cc: embray, tscrim, jdemeyer, vbraun Merged in:
Authors: Frédéric Chapoton Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: b270f8c (Commits, GitHub, GitLab) Commit: b270f8c96088c5679f62f79c0b7706230618ed42
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

as a step towards python3

let us remove the few existing instances of "from string import join"

one is in a script that is run early in sage installation

Change History (9)

comment:1 Changed 5 years ago by chapoton

  • Branch set to public/20909
  • Commit set to 7058f361bd60c6bf742e8dd77df339c1f1102fd6
  • Status changed from new to needs_review

New commits:

​7058f36getting rid of from string import join

comment:2 Changed 5 years ago by git

  • Commit changed from 7058f361bd60c6bf742e8dd77df339c1f1102fd6 to a28c594d659445c663abe57958eefbb9b7db5963

Branch pushed to git repo; I updated commit sha1. New commits:

​a28c594one more string.join removed

comment:3 Changed 5 years ago by chapoton

  • Cc embray tscrim jdemeyer added

comment:4 Changed 5 years ago by git

  • Commit changed from a28c594d659445c663abe57958eefbb9b7db5963 to b270f8c96088c5679f62f79c0b7706230618ed42

Branch pushed to git repo; I updated commit sha1. New commits:

​b270f8cone more import join removed

comment:5 Changed 5 years ago by chapoton

  • Cc vbraun added
  • Description modified (diff)

comment:6 Changed 5 years ago by embray

  • Status changed from needs_review to positive_review

I think some of the code you updated was questionable in the first place. But best for this to just focus on the string.join > str.join conversion and not tinker with anything else.

comment:7 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name missing

comment:8 Changed 5 years ago by chapoton

  • Reviewers set to Erik Bray
  • Status changed from needs_work to positive_review

comment:9 Changed 5 years ago by vbraun

  • Branch changed from public/20909 to b270f8c96088c5679f62f79c0b7706230618ed42
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.