Opened 6 years ago
Closed 6 years ago
#20909 closed defect (fixed)
not using string.join any longer
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.3 |
Component: | python3 | Keywords: | |
Cc: | embray, tscrim, jdemeyer, vbraun | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Erik Bray |
Report Upstream: | N/A | Work issues: | |
Branch: | b270f8c (Commits, GitHub, GitLab) | Commit: | b270f8c96088c5679f62f79c0b7706230618ed42 |
Dependencies: | Stopgaps: |
Description (last modified by )
as a step towards python3
let us remove the few existing instances of "from string import join"
one is in a script that is run early in sage installation
Change History (9)
comment:1 Changed 6 years ago by
- Branch set to public/20909
- Commit set to 7058f361bd60c6bf742e8dd77df339c1f1102fd6
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Commit changed from 7058f361bd60c6bf742e8dd77df339c1f1102fd6 to a28c594d659445c663abe57958eefbb9b7db5963
Branch pushed to git repo; I updated commit sha1. New commits:
a28c594 | one more string.join removed
|
comment:3 Changed 6 years ago by
- Cc embray tscrim jdemeyer added
comment:4 Changed 6 years ago by
- Commit changed from a28c594d659445c663abe57958eefbb9b7db5963 to b270f8c96088c5679f62f79c0b7706230618ed42
Branch pushed to git repo; I updated commit sha1. New commits:
b270f8c | one more import join removed
|
comment:5 Changed 6 years ago by
- Cc vbraun added
- Description modified (diff)
comment:6 Changed 6 years ago by
- Status changed from needs_review to positive_review
I think some of the code you updated was questionable in the first place. But best for this to just focus on the string.join
> str.join
conversion and not tinker with anything else.
comment:7 Changed 6 years ago by
- Status changed from positive_review to needs_work
Reviewer name missing
comment:8 Changed 6 years ago by
- Reviewers set to Erik Bray
- Status changed from needs_work to positive_review
comment:9 Changed 6 years ago by
- Branch changed from public/20909 to b270f8c96088c5679f62f79c0b7706230618ed42
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
getting rid of from string import join