Opened 5 years ago

Closed 5 years ago

#20906 closed defect (fixed)

rank is missing in Combinatorial free modules

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: combinatorics Keywords:
Cc: tscrim, nthiery Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 6da9587 (Commits, GitHub, GitLab) Commit: 6da95873128a95f4fc1dd70b613aa01293603b7a
Dependencies: Stopgaps:

Status badges

Description

comb. free modules do not have ranks as synonym method of dimension

let us add the alias

motivation: this fails 

sage: V3=CombinatorialFreeModule(QQ,['a','b','c'])
sage: T=End(V3)
sage: from sage.modules.matrix_morphism import MatrixMorphism
sage: MatrixMorphism(T,matrix(QQ,[[1,2,3],[2,3,4],[3,4,5]]))

Change History (5)

comment:1 Changed 5 years ago by chapoton

  • Branch set to u/chapoton/20906
  • Commit set to 6da95873128a95f4fc1dd70b613aa01293603b7a
  • Status changed from new to needs_review

New commits:

​6da9587add missing rank in combinatorial free modules

comment:2 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 5 years ago by chapoton

Thanks. Sadly, that does not solve all the problems in my code snippet. The matrix morphism is now defined, but useless. Cannot be powered, or made acting on a vector.

comment:4 Changed 5 years ago by tscrim

I think that has more to do with the fact that CFM's and Sage's free module code is still mostly separate. However, this is progress in fusing their API's.

comment:5 Changed 5 years ago by vbraun

  • Branch changed from u/chapoton/20906 to 6da95873128a95f4fc1dd70b613aa01293603b7a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.