Opened 6 years ago

Last modified 6 years ago

#20901 closed defect

Upgrade bliss package to 0.73 with Debian patches; install header files in location expected by polymake — at Version 11

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-7.3
Component: packages: optional Keywords:
Cc: Jernej Azarija, Jeroen Demeyer, Vincent Delecroix, Karl-Dieter Crisman, Dima Pasechnik, Frédéric Chapoton, Christian Stump, Moritz Firsching, Volker Braun Merged in:
Authors: Matthias Koeppe Reviewers:
Report Upstream: Reported upstream. No feedback yet. Work issues:
Branch: u/mkoeppe/upgrade_bliss_package_to_0_73_with_debian_patches__install_header_files_in_location_expected_by_polymake (Commits, GitHub, GitLab) Commit: 4b222118c057b1f870121951b44f6f851029ec63
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

New upstream archive: http://www.tcs.hut.fi/Software/bliss/bliss-0.73.zip (we have 0.72)

Upstream bliss does not have a proper build system (in particular no 'make install'). "spkg-install" installs header files with generic names such as "graph.hh" flat into $SAGE_LOCAL/include/

Debian has https://packages.debian.org/sid/math/bliss which autotoolizes the package and adjust the include file location. This matches where Polymake (#20892) expects the header files.

The patch in this package is generated by making a diff from the original tarball with the distribution here: https://github.com/mkoeppe/bliss/releases/download/apply_debian_patches%2F0.73-1/bliss-0.73.debian-1.tar.gz

Change History (11)

comment:1 Changed 6 years ago by Matthias Köppe

Dependencies: #20692

comment:2 Changed 6 years ago by Karl-Dieter Crisman

Cc: Karl-Dieter Crisman added; crisman removed

comment:3 Changed 6 years ago by Matthias Köppe

Branch: u/mkoeppe/upgrade_bliss_package_to_0_73_with_debian_patches__install_header_files_in_location_expected_by_polymake

comment:4 Changed 6 years ago by Matthias Köppe

Authors: Matthias Koeppe
Cc: Dima Pasechnik Frédéric Chapoton Christian Stump Moritz Firsching added
Commit: 3837a489fff9a294566061755664e240a7a5a1ff
Dependencies: #20692
Description: modified (diff)
Status: newneeds_review

New commits:

3837a48bliss: Use autotoolized package from Debian

comment:5 Changed 6 years ago by Matthias Köppe

Needs review. Prerequisite for polymake (#20892).

comment:6 Changed 6 years ago by Dima Pasechnik

what are the new goodies? a shared library?

comment:7 in reply to:  6 Changed 6 years ago by Matthias Köppe

Replying to dimpase:

what are the new goodies? a shared library?

A shared library, proper include files location, and as a result works as a prerequisite for polymake. New upstream version -- but upstream is silent about what has changed compared to 0.72.

comment:8 Changed 6 years ago by git

Commit: 3837a489fff9a294566061755664e240a7a5a1ff225755e087890955539c2ee70f838b6631f0ee57

Branch pushed to git repo; I updated commit sha1. New commits:

225755ebliss: Add more info in SPKG.txt

comment:9 Changed 6 years ago by Jeroen Demeyer

The usual way to ship packages in Sage is to start from the original unmodified sources and then apply patches (either at packaging time or at build time). Here, you are instead forking upstream for no clear reason.

comment:10 Changed 6 years ago by git

Commit: 225755e087890955539c2ee70f838b6631f0ee574b222118c057b1f870121951b44f6f851029ec63

Branch pushed to git repo; I updated commit sha1. New commits:

4b22211bliss: Use upstream tarball and patches

comment:11 in reply to:  9 Changed 6 years ago by Matthias Köppe

Description: modified (diff)

Replying to jdemeyer:

The usual way to ship packages in Sage is to start from the original unmodified sources and then apply patches (either at packaging time or at build time). Here, you are instead forking upstream for no clear reason.

OK, I've changed it to using upstream + a patch. Unfortunately our patches cannot be as elegant as Debian's because we cannot rely on the availability of autotools. So my patch has to ship the whole autogenerated build system.

Note: See TracTickets for help on using tickets.