Opened 5 years ago

Closed 5 years ago

#20878 closed enhancement (fixed)

PointConfiguration: Add plot method

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-7.3
Component: geometry Keywords:
Cc: vbraun, vdelecroix, chapoton, jdemeyer Merged in:
Authors: Matthias Koeppe Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 91b7086 (Commits, GitHub, GitLab) Commit: 91b7086e62c4aa0812141843d69ce1caebb76da5
Dependencies: Stopgaps:

Status badges

Description

Triangulations of point configurations can be plotted; but the configurations themselves can't. This ticket adds a plot method to fix this.

Change History (9)

comment:1 Changed 5 years ago by mkoeppe

  • Branch set to u/mkoeppe/pointconfiguration__add_plot_method

comment:2 Changed 5 years ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc vbraun vdelecroix chapoton jdemeyer added
  • Commit set to 4ffc1e160a3cb6db371700381f66e3ca55759371
  • Status changed from new to needs_review

New commits:

4ffc1e1PointConfiguration: Add plot method

comment:3 follow-up: Changed 5 years ago by tscrim

It would be good to add the plot to the documentation using the .. PLOT:: directive (see, e.g., knots/link.py).

comment:4 Changed 5 years ago by git

  • Commit changed from 4ffc1e160a3cb6db371700381f66e3ca55759371 to 77a1eafbe1f4a0bc185c7a53b52c72a0723c99ec

Branch pushed to git repo; I updated commit sha1. New commits:

77a1eafAdd some .. PLOT directives

comment:5 in reply to: ↑ 3 Changed 5 years ago by mkoeppe

Replying to tscrim:

It would be good to add the plot to the documentation using the .. PLOT:: directive (see, e.g., knots/link.py).

OK, I have added a few.

comment:6 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

If you could also add a plot in the plot() method, then you can set a positive review on my behalf.

Version 0, edited 5 years ago by tscrim (next)

comment:7 Changed 5 years ago by git

  • Commit changed from 77a1eafbe1f4a0bc185c7a53b52c72a0723c99ec to 91b7086e62c4aa0812141843d69ce1caebb76da5

Branch pushed to git repo; I updated commit sha1. New commits:

91b7086PointConfiguration.plot: Add .. PLOT:: directive

comment:8 Changed 5 years ago by mkoeppe

  • Status changed from needs_review to positive_review

Thanks for reviewing, Travis!

comment:9 Changed 5 years ago by vbraun

  • Branch changed from u/mkoeppe/pointconfiguration__add_plot_method to 91b7086e62c4aa0812141843d69ce1caebb76da5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.