Opened 4 years ago

Closed 4 years ago

#20869 closed enhancement (fixed)

better check for correct pprof

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: misc Keywords: pprof
Cc: vbraun, embray, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: a001136 (Commits) Commit: a001136300dc8a58a04219548968b5a23369c5fd
Dependencies: Stopgaps:

Description (last modified by chapoton)

Currently the check for availability of pprof sometimes breaks the doctest.

Here is a more silent version.

See for example the patchbot report:

https://patchbot.sagemath.org/log/20154/Ubuntu/14.04/x86_64/3.16.0-71-generic/irma-atlas/2016-06-23%2014:06:20?short

Change History (5)

comment:1 Changed 4 years ago by chapoton

  • Cc vbraun embray jdemeyer added
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/20869
  • Commit set to 691ee4e2926447bd7533ea2ce295a0f0d4c6664c

New commits:

a827087trac 20736 first try, failing
c9907eftrac 20736 change in dependencies
f3839fdanother try, failing the same way
160332cfixing the spkg-install script
eed116fMerge branch 'public/20736' into 7.3.b4
228842bupdate of patchbot to 2.6.0
91fc492patchbot : trying to use pip install
897f5b2trac 20736 removing patchbot as spkg
691ee4etrac 20869 enhance pprof recognition

comment:3 Changed 4 years ago by chapoton

  • Commit changed from 691ee4e2926447bd7533ea2ce295a0f0d4c6664c to a001136300dc8a58a04219548968b5a23369c5fd

oops, wrong branch, now corrected


New commits:

a001136trac 20869 better recognition for pprof

comment:4 Changed 4 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/20869 to a001136300dc8a58a04219548968b5a23369c5fd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.