Opened 5 years ago
Closed 5 years ago
#20857 closed enhancement (fixed)
Implement an() for modular forms
Reported by:  klui  Owned by:  

Priority:  minor  Milestone:  sage7.3 
Component:  modular forms  Keywords:  modular form, q expansion 
Cc:  Merged in:  
Authors:  Kevin Lui  Reviewers:  Peter Bruin, William Stein 
Report Upstream:  N/A  Work issues:  
Branch:  e5fc480 (Commits, GitHub, GitLab)  Commit:  e5fc48064b490ac4e4bdc432885b38c0eaea3e27 
Dependencies:  Stopgaps: 
Description (last modified by )
If f is a newform, then f.an(n) will return the nth coefficient in its qexpansion.
Change History (14)
comment:1 Changed 5 years ago by
 Branch set to u/klui/implement_an___for_modular_forms
comment:2 Changed 5 years ago by
 Commit set to 1aa31cfc9509132b0684479ed2f9535163bceea1
 Description modified (diff)
comment:3 Changed 5 years ago by
 Status changed from new to needs_review
comment:4 followup: ↓ 6 Changed 5 years ago by
 Status changed from needs_review to needs_info
Would it be an option to call this method coefficient()
instead? This would be more descriptive in my opinion, and would mean that the existing, but currently useless, method coefficient()
becomes useful.
comment:5 Changed 5 years ago by
 Commit changed from 1aa31cfc9509132b0684479ed2f9535163bceea1 to e5fc48064b490ac4e4bdc432885b38c0eaea3e27
Branch pushed to git repo; I updated commit sha1. New commits:
e5fc480  changed name from an to coefficient

comment:6 in reply to: ↑ 4 Changed 5 years ago by
Replying to pbruin:
Would it be an option to call this method
coefficient()
instead? This would be more descriptive in my opinion, and would mean that the existing, but currently useless, methodcoefficient()
becomes useful.
Good idea. I changed it.
comment:7 Changed 5 years ago by
 Status changed from needs_info to needs_review
comment:8 Changed 5 years ago by
This change violates the deprecation policy. You can't just delete methods from the public API. http://doc.sagemath.org/html/en/developer/coding_in_python.html#deprecation
comment:9 Changed 5 years ago by
 Status changed from needs_review to needs_work
comment:10 Changed 5 years ago by
WOOPS  I was incorrectly looking at the diff (only the second one). This looks fine and makes a lot of sense.
comment:11 Changed 5 years ago by
 Status changed from needs_work to positive_review
comment:12 Changed 5 years ago by
 Status changed from positive_review to needs_work
Reviewer name is missing...
comment:13 Changed 5 years ago by
 Reviewers set to Peter Bruin, William Stein
 Status changed from needs_work to positive_review
comment:14 Changed 5 years ago by
 Branch changed from u/klui/implement_an___for_modular_forms to e5fc48064b490ac4e4bdc432885b38c0eaea3e27
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
added an() method to newforms