Opened 5 years ago

Closed 5 years ago

#20857 closed enhancement (fixed)

Implement an() for modular forms

Reported by: klui Owned by:
Priority: minor Milestone: sage-7.3
Component: modular forms Keywords: modular form, q expansion
Cc: Merged in:
Authors: Kevin Lui Reviewers: Peter Bruin, William Stein
Report Upstream: N/A Work issues:
Branch: e5fc480 (Commits, GitHub, GitLab) Commit: e5fc48064b490ac4e4bdc432885b38c0eaea3e27
Dependencies: Stopgaps:

Status badges

Description (last modified by klui)

If f is a newform, then f.an(n) will return the nth coefficient in its q-expansion.

Change History (14)

comment:1 Changed 5 years ago by klui

  • Branch set to u/klui/implement_an___for_modular_forms

comment:2 Changed 5 years ago by klui

  • Authors set to Kevin Lui
  • Commit set to 1aa31cfc9509132b0684479ed2f9535163bceea1
  • Description modified (diff)

New commits:

1aa31cfadded an() method to newforms

comment:3 Changed 5 years ago by klui

  • Status changed from new to needs_review

comment:4 follow-up: Changed 5 years ago by pbruin

  • Status changed from needs_review to needs_info

Would it be an option to call this method coefficient() instead? This would be more descriptive in my opinion, and would mean that the existing, but currently useless, method coefficient() becomes useful.

comment:5 Changed 5 years ago by git

  • Commit changed from 1aa31cfc9509132b0684479ed2f9535163bceea1 to e5fc48064b490ac4e4bdc432885b38c0eaea3e27

Branch pushed to git repo; I updated commit sha1. New commits:

e5fc480changed name from an to coefficient

comment:6 in reply to: ↑ 4 Changed 5 years ago by klui

Replying to pbruin:

Would it be an option to call this method coefficient() instead? This would be more descriptive in my opinion, and would mean that the existing, but currently useless, method coefficient() becomes useful.

Good idea. I changed it.

comment:7 Changed 5 years ago by klui

  • Status changed from needs_info to needs_review

comment:8 Changed 5 years ago by was

This change violates the deprecation policy. You can't just delete methods from the public API. http://doc.sagemath.org/html/en/developer/coding_in_python.html#deprecation

comment:9 Changed 5 years ago by was

  • Status changed from needs_review to needs_work

comment:10 Changed 5 years ago by was

WOOPS -- I was incorrectly looking at the diff (only the second one). This looks fine and makes a lot of sense.

comment:11 Changed 5 years ago by was

  • Status changed from needs_work to positive_review

comment:12 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name is missing...

comment:13 Changed 5 years ago by pbruin

  • Reviewers set to Peter Bruin, William Stein
  • Status changed from needs_work to positive_review

comment:14 Changed 5 years ago by vbraun

  • Branch changed from u/klui/implement_an___for_modular_forms to e5fc48064b490ac4e4bdc432885b38c0eaea3e27
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.