Opened 6 years ago

Closed 4 years ago

#20856 closed enhancement (wontfix)

Improve sql database functionality

Reported by: Vincent Delecroix Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: misc Keywords:
Cc: Samuel Lelièvre Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

In order to support #20695 one needs some simple cleaning and enhancement in sql_database.py.

Change History (10)

comment:1 Changed 6 years ago by Vincent Delecroix

Branch: u/vdelecroix/20856
Status: newneeds_review

comment:2 Changed 6 years ago by git

Commit: ffa92c62ededebf52acfa38f4c83aad109e860c4

Branch pushed to git repo; I updated commit sha1. New commits:

ffa92c6Better sql database handle.

comment:3 Changed 6 years ago by Samuel Lelièvre

Cc: Samuel Lelièvre added
Summary: better sql databaseImprove sql database functionality
  • In the method _create_print_table, the argument col_titles was renamed cols; please update the INPUT section accordingly.
  • Take this opportunity to change the one-line description from Creates to Create.
  • Some spaces are missing after commas in structures like for a,b in c or in function or method arguments.

comment:4 Changed 6 years ago by git

Commit: ffa92c62ededebf52acfa38f4c83aad109e860c437e8f89372dfb5971f5ab9fd96722d7a67152d8f

Branch pushed to git repo; I updated commit sha1. New commits:

37e8f89doc and pep8

comment:5 Changed 6 years ago by Sébastien Labbé

Status: needs_reviewneeds_work

Can you add a doctest showing how the code is enhanced?

comment:6 Changed 5 years ago by Vincent Delecroix

Authors: Vincent Delecroix
Milestone: sage-7.3sage-duplicate/invalid/wontfix

It seems simpler to just copy/paste the file I need from Sage. This is a shame.


New commits:

ffa92c6Better sql database handle.
37e8f89doc and pep8

comment:7 Changed 5 years ago by Vincent Delecroix

Branch: u/vdelecroix/20856
Commit: 37e8f89372dfb5971f5ab9fd96722d7a67152d8f

comment:8 Changed 5 years ago by Vincent Delecroix

Status: needs_workneeds_review

comment:9 Changed 5 years ago by Frédéric Chapoton

Status: needs_reviewpositive_review

comment:10 Changed 4 years ago by Vincent Delecroix

Resolution: wontfix
Status: positive_reviewclosed

closing positively reviewed duplicates

Note: See TracTickets for help on using tickets.