Changes between Initial Version and Version 1 of Ticket #20849, comment 4
 Timestamp:
 Aug 25, 2016, 11:17:10 AM (6 years ago)
Legend:
 Unmodified
 Added
 Removed
 Modified

Ticket #20849, comment 4
initial v1 9 9  `minimum_distance` the new doc string is less clear than previous one. The notion of minimum distance is clear in coding theory, no need to be explicit. If you really want to explicit it, change the sentence of the new docstring to `Returns the minimum distance between any two words in ``self``.` 10 10 11  ` parity_column_multipliers` the new docstring speaks about "positions scalars", while I guess it should be column multipliers, since the evaluation points are the same for the code and its dual.11  `column_multipliers`, `parity_column_multipliers`: the new doc strings speaks about positions scalars, while these methods deal with multipliers. 12 12 13  `weight_enumerator`: it would be better to say "the polynomial whose coefficient of degree is [...]" t his avoidsnaming the variable 'x'13  `weight_enumerator`: it would be better to say "the polynomial whose coefficient of degree is [...]" to avoid naming the variable 'x' 14 14 15  (several places) the framework for describing the encoding could be made a bit more clear, using the vocables "message" and "encoding" more explicitly. Instead of15  (several places) the framework for describing the encoding could be made a bit more clear, using the terms "message" and "encoding" more explicitly. Instead of 16 16 17 17 {{{ … … 22 22 what about 23 23 {{{ 24 let `m [...] over F` be the message24 let `m=[...]` a vector over F be the message: 25 25 [...] 26 26 the encoding of `m` will be the following codeword: 27 27 }}} 28  `class GRSErrorErasureDecoder(Decoder)` it would be better to say : floor((d1)/2 instead of "decoding radius". Also the input to the decode method should be a `word_and_erasure` vector, not a vector `y`. 29 30 Daniel