Opened 5 years ago

Closed 5 years ago

#20837 closed task (fixed)

Cleanup patching of some spkgs

Reported by: embray Owned by:
Priority: minor Milestone: sage-7.3
Component: build Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: f88a406 (Commits, GitHub, GitLab) Commit: f88a406281a2a0346e354ab5edd3837cad0e5023
Dependencies: Stopgaps:

Status badges


Update some patches so that *all* patches to spkgs are applied with patch -p1 from the root of the upstream source. There were only a handful of oddballs in this regard:

  • cddlib
  • gfan
  • pygments

(In the case of pygments the patches were formatted correctly, but were being applied *before* cd src/ instead of after.)

Standardizing this across all spkgs is a prerequisite to moving forward on #20692, where we decided it would be good to run patch automatically on every spkg by default.

Change History (3)

comment:1 Changed 5 years ago by embray

  • Authors set to Erik Bray
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:3 Changed 5 years ago by vbraun

  • Branch changed from u/embray/patch-cleanup-a to f88a406281a2a0346e354ab5edd3837cad0e5023
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.