Opened 17 months ago

Closed 6 months ago

#20833 closed enhancement (duplicate)

Improve _sage_src_lines_()

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: documentation Keywords:
Cc: nthiery Merged in:
Authors: Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Currently, _sage_src_lines_() is used both to get the source lines of a class (e.g. dynamic classes) and an instance (e.g. cached functions). We change this to always mean the source lines of an instance. This makes things clearer and removes a hack involving getattr_from_other_class() (see #20686).

Change History (6)

comment:1 Changed 17 months ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 17 months ago by jdemeyer

testing

comment:3 Changed 17 months ago by jdemeyer

  • Milestone changed from sage-7.3 to sage-duplicate/invalid/wontfix

comment:4 Changed 6 months ago by chapoton

  • Status changed from new to needs_review

comment:5 Changed 6 months ago by chapoton

  • Status changed from needs_review to positive_review

comment:6 Changed 6 months ago by jdemeyer

  • Authors Jeroen Demeyer deleted
  • Resolution set to duplicate
  • Reviewers set to Frédéric Chapoton
  • Status changed from positive_review to closed

Indeed, this was too hard to separate from #20686 and fixed there.

Note: See TracTickets for help on using tickets.