Opened 3 years ago

Closed 3 years ago

#20825 closed enhancement (fixed)

EvaluationMethods should be a new-style class

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.3
Component: symbolics Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 44e80b3 (Commits) Commit: 44e80b30d32d5b6d35c00edecf81d4313dc1c11f
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Some of the changes I'm making to #20686 will break EvaluationMethods otherwise. And with Python 3, every class is new-style anyway.

Change History (6)

comment:1 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/20825

comment:2 Changed 3 years ago by git

  • Commit set to 44e80b30d32d5b6d35c00edecf81d4313dc1c11f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

44e80b3EvaluationMethods should be a new-style class

comment:3 Changed 3 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from new to needs_review

comment:4 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/20825 to 44e80b30d32d5b6d35c00edecf81d4313dc1c11f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.