Opened 6 years ago

Closed 6 years ago

#20825 closed enhancement (fixed)

EvaluationMethods should be a new-style class

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.3
Component: symbolics Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 44e80b3 (Commits, GitHub, GitLab) Commit: 44e80b30d32d5b6d35c00edecf81d4313dc1c11f
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

Some of the changes I'm making to #20686 will break EvaluationMethods otherwise. And with Python 3, every class is new-style anyway.

Change History (6)

comment:1 Changed 6 years ago by Jeroen Demeyer

Branch: u/jdemeyer/ticket/20825

comment:2 Changed 6 years ago by git

Commit: 44e80b30d32d5b6d35c00edecf81d4313dc1c11f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

44e80b3EvaluationMethods should be a new-style class

comment:3 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)
Status: newneeds_review

comment:4 Changed 6 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:5 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)

comment:6 Changed 6 years ago by Volker Braun

Branch: u/jdemeyer/ticket/2082544e80b30d32d5b6d35c00edecf81d4313dc1c11f
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.