Opened 6 years ago
Closed 6 years ago
#20816 closed enhancement (fixed)
pep8 in magma interface
Reported by: | Frédéric Chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.3 |
Component: | interfaces: optional | Keywords: | magma |
Cc: | Travis Scrimshaw, Jeroen Demeyer | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | cd6daf2 (Commits, GitHub, GitLab) | Commit: | cd6daf2a45bcf981f04d7c95ede61ee30c27b116 |
Dependencies: | Stopgaps: |
Description
A little cleanup of interfaces/magma
and one change to a more stable doctest
(so that all tests pass)
Change History (7)
comment:1 Changed 6 years ago by
Branch: | → u/chapoton/20816 |
---|---|
Commit: | → cd6daf2a45bcf981f04d7c95ede61ee30c27b116 |
Status: | new → needs_review |
comment:2 Changed 6 years ago by
Cc: | Travis Scrimshaw Jori Mäntysalo Jeroen Demeyer added |
---|
comment:4 follow-up: 5 Changed 6 years ago by
Reviewers: | → Travis Scrimshaw |
---|
LGTM modulo this change:
- sage: v = V.list_attributes(); v.sort(); v # optional - magma - ['Coroots', 'Involution', 'M', 'RootDatum', 'Roots', 'StrLocalData', 'T', 'decomp', 'eisen', 'exthom', 'hSplit', 'ip_form', 'p', 'ssbasis', 'weights'] + sage: v = V.list_attributes(); v.sort() # optional - magma + sage: print(v) # optional - magma + ['Coroots', 'Involution', ..., 'p', 'ssbasis', 'weights']
Is there a reason why we don't keep all of them (I don't have magma so I can't check)? Also, the print
is vacuous to me.
comment:5 Changed 6 years ago by
Replying to tscrim:
LGTM modulo this change:
- sage: v = V.list_attributes(); v.sort(); v # optional - magma - ['Coroots', 'Involution', 'M', 'RootDatum', 'Roots', 'StrLocalData', 'T', 'decomp', 'eisen', 'exthom', 'hSplit', 'ip_form', 'p', 'ssbasis', 'weights'] + sage: v = V.list_attributes(); v.sort() # optional - magma + sage: print(v) # optional - magma + ['Coroots', 'Involution', ..., 'p', 'ssbasis', 'weights']Is there a reason why we don't keep all of them (I don't have magma so I can't check)? Also, the
Yes, this is the core of this ticket, making this precise doctest more robust by allowing some changes in the list of attributes. I ran the doctest on a machine with the latest magma and it was failing because of the presence of two more attributes. The aim of the test is not to check that we are up-to-date with a precise version of magma, but that we can indeed manage to get the attributes from magma itself.
comment:6 Changed 6 years ago by
Status: | needs_review → positive_review |
---|
Okay, thanks. Then in it goes.
comment:7 Changed 6 years ago by
Branch: | u/chapoton/20816 → cd6daf2a45bcf981f04d7c95ede61ee30c27b116 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
New commits:
full pep8 in magma interface, and one more stable doctest