Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#20813 closed enhancement (fixed)

Change (second time) integer divisions from / to //

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: python3 Keywords: divison
Cc: tscrim, jmantysalo, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: 0f4bcb7 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by chapoton)

re-do some changes of #20533,

towards using python3 style of division,

that were (by my fault) undone by #18659

Change History (10)

comment:1 Changed 5 years ago by chapoton

  • Branch set to public/20813
  • Cc tscrim jmantysalo jdemeyer added
  • Commit set to c41ec6b45a1976d210e453e10f8af2925a4eea6f
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

c41ec6bfixing (again some divisions in combinat)

comment:2 Changed 5 years ago by git

  • Commit changed from c41ec6b45a1976d210e453e10f8af2925a4eea6f to 9bc83d94bf12bb7dc08c036cd47e3feb3ecb0197

Branch pushed to git repo; I updated commit sha1. New commits:

9bc83d9one detail

comment:3 Changed 5 years ago by jmantysalo

The patch seems good (and doctest of modified files passed), but is there some error in branches? The title says "in combinat", but none of the files are at combinat-folder.

After "In Python3, the division of Python integers returns a float instead." there could be something like "In both Python2 and Python3 will // give an euclidean division." or something like that.

comment:4 Changed 5 years ago by git

  • Commit changed from 9bc83d94bf12bb7dc08c036cd47e3feb3ecb0197 to 0f4bcb7d25b94335a9c5fde1b534d10623670ecd

Branch pushed to git repo; I updated commit sha1. New commits:

0f4bcb7trac 20813 detail

comment:5 follow-up: Changed 5 years ago by chapoton

  • Summary changed from Change (second time) integer divisions from / to // in combinat to Change (second time) integer divisions from / to //

One of the changed file is in combinat.

I removed combinat from the title of the ticket.

comment:6 in reply to: ↑ 5 Changed 5 years ago by jmantysalo

  • Status changed from needs_review to positive_review

Replying to chapoton:

One of the changed file is in combinat.

Duh. I am blind.

This OK.

comment:7 follow-up: Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

reviewer name

comment:8 in reply to: ↑ 7 Changed 5 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo
  • Status changed from needs_work to positive_review

Replying to vbraun:

reviewer name

Arghs. Trac should reject positive review with empty reviewer name.

comment:9 Changed 5 years ago by vbraun

  • Branch changed from public/20813 to 0f4bcb7d25b94335a9c5fde1b534d10623670ecd
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 Changed 3 years ago by embray

  • Commit 0f4bcb7d25b94335a9c5fde1b534d10623670ecd deleted
  • Keywords divison added
Note: See TracTickets for help on using tickets.