Opened 6 years ago

Closed 6 years ago

#20799 closed enhancement (fixed)

cleanup of ell_tate_curve

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-7.3
Component: elliptic curves Keywords:
Cc: cremona Merged in:
Authors: Frédéric Chapoton Reviewers: Chris Wuthrich
Report Upstream: N/A Work issues:
Branch: 82df4ac (Commits, GitHub, GitLab) Commit: 82df4ac603b5a912220b2efd32589cb96f64169a
Dependencies: Stopgaps:

Status badges

Description

essentially cosmetic changes, toward pep8 style

Change History (5)

comment:1 Changed 6 years ago by chapoton

  • Branch set to public/20799
  • Commit set to 37b084f606519c7a9e48ddca06bb60907a4f9392
  • Status changed from new to needs_review

New commits:

37b084ffull pep8 cleanup for ell_tate_curve.py

comment:2 Changed 6 years ago by git

  • Commit changed from 37b084f606519c7a9e48ddca06bb60907a4f9392 to 82df4ac603b5a912220b2efd32589cb96f64169a

Branch pushed to git repo; I updated commit sha1. New commits:

7a14b01Merge branch 'public/20799' into 7.3.b4
82df4actrac 20799 fixing 2 duplicate references

comment:3 Changed 6 years ago by chapoton

  • Cc cremona added

This is a rather trivial ticket, doing only cosmetic changes to this file.

  • better handling of references
  • putting code in pep8 standard

Nothing really serious, should be easy to check.

comment:4 Changed 6 years ago by wuthrich

  • Reviewers set to Chris Wuthrich
  • Status changed from needs_review to positive_review

Indeed a simple one to review.

After merging with 7.3.beta6, all pass and all changes are good. Thanks.

(By the way, Frédéric, feel free to CC me for such tickets, especially when I am to blame anyway.)

comment:5 Changed 6 years ago by vbraun

  • Branch changed from public/20799 to 82df4ac603b5a912220b2efd32589cb96f64169a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.