Opened 6 years ago

Closed 6 years ago

#20797 closed defect (fixed)

loading remote files is broken

Reported by: novoselt Owned by:
Priority: major Milestone: sage-7.3
Component: misc Keywords:
Cc: chapoton Merged in:
Authors: Andrey Novoseltsev Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 5f257e0 (Commits, GitHub, GitLab) Commit: 5f257e00fa682c7b0a977d87c68fb441ac52ee51
Dependencies: Stopgaps:

Status badges

Description

In 7.2 we have 

novoselt@sage:~/sage$ sage -t --optional=internet src/sage/misc/remote_file.py 
...
File "src/sage/misc/remote_file.py", line 23, in sage.misc.remote_file.get_remote_file
Failed example:
    g = get_remote_file("http://sagemath.org/ack.html", verbose=False)   # optional - internet
Exception raised:
    Traceback (most recent call last):
      File "/home/novoselt/sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 498, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/novoselt/sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 861, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.misc.remote_file.get_remote_file[0]>", line 1, in <module>
        g = get_remote_file("http://sagemath.org/ack.html", verbose=False)   # optional - internet
      File "/home/novoselt/sage/local/lib/python2.7/site-packages/sage/misc/remote_file.py", line 36, in get_remote_file
        from six.moves.urllib.request import urlretrieve
    ImportError: No module named moves.urllib.request

Change History (4)

comment:1 Changed 6 years ago by novoselt

  • Branch set to u/novoselt/remote_future

comment:2 Changed 6 years ago by novoselt

  • Commit set to 5f257e00fa682c7b0a977d87c68fb441ac52ee51
  • Status changed from new to needs_review

New commits:

​5f257e0Deal with six module in misc conflicting with package six.

comment:3 Changed 6 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

comment:4 Changed 6 years ago by vbraun

  • Branch changed from u/novoselt/remote_future to 5f257e00fa682c7b0a977d87c68fb441ac52ee51
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.